From d219507d6373d49ba8e172a19540ad3f559c4088 Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Fri, 4 Apr 2014 11:55:21 +0200 Subject: sgsn: Comparing array to NULL is not useful .v is a unsigned char array with up-to 255 elements. We do not need to add a null check here. Fixes: Coverity CID 1040719 --- openbsc/src/gprs/gprs_gmm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'openbsc') diff --git a/openbsc/src/gprs/gprs_gmm.c b/openbsc/src/gprs/gprs_gmm.c index f7a5cde00..6ba385558 100644 --- a/openbsc/src/gprs/gprs_gmm.c +++ b/openbsc/src/gprs/gprs_gmm.c @@ -1221,7 +1221,7 @@ int gsm48_tx_gsm_act_pdp_acc(struct sgsn_pdp_ctx *pdp) pdp->lib->eua.v[0] |= 0xf0; /* Optional: Protocol configuration options (FIXME: why 'req') */ - if (pdp->lib->pco_req.l && pdp->lib->pco_req.v) + if (pdp->lib->pco_req.l) msgb_tlv_put(msg, GSM48_IE_GSM_PROTO_CONF_OPT, pdp->lib->pco_req.l, pdp->lib->pco_req.v); -- cgit v1.2.3