From a7313dd886306bed59df5aedb029a5c671f199a7 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Mon, 29 Feb 2016 09:35:54 +0100 Subject: osmo_bsc_filter.c: add fixme note --- openbsc/src/osmo-bsc/osmo_bsc_filter.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'openbsc/src/osmo-bsc') diff --git a/openbsc/src/osmo-bsc/osmo_bsc_filter.c b/openbsc/src/osmo-bsc/osmo_bsc_filter.c index e9757337d..f58034702 100644 --- a/openbsc/src/osmo-bsc/osmo_bsc_filter.c +++ b/openbsc/src/osmo-bsc/osmo_bsc_filter.c @@ -264,6 +264,9 @@ static int bsc_patch_mm_info(struct gsm_subscriber_connection *conn, parse_res = tlv_parse(&tp, &gsm48_mm_att_tlvdef, data, length, 0, 0); if (parse_res <= 0 && parse_res != -3) + /* FIXME: -3 means unknown IE error, so this accepts messages + * with unknown IEs. But parsing has aborted with the unknown + * IE and the message is broken or parsed incompletely. */ return 0; /* Is TZ patching enabled? */ -- cgit v1.2.3