From 6d718c054ad2bce52548bcac1def61085a15391c Mon Sep 17 00:00:00 2001 From: Daniel Willmann Date: Sat, 16 Jul 2011 21:50:13 +0200 Subject: osmo-bsc: Improve return handling in verify_net_loc --- openbsc/src/osmo-bsc/osmo_bsc_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'openbsc/src/osmo-bsc/osmo_bsc_main.c') diff --git a/openbsc/src/osmo-bsc/osmo_bsc_main.c b/openbsc/src/osmo-bsc/osmo_bsc_main.c index 3a2306c94..1b914688e 100644 --- a/openbsc/src/osmo-bsc/osmo_bsc_main.c +++ b/openbsc/src/osmo-bsc/osmo_bsc_main.c @@ -220,7 +220,6 @@ oom: int verify_net_loc(struct ctrl_cmd *cmd, const char *value, void *data) { char *saveptr, *latstr, *lonstr, *heightstr, *agestr, *tmp; - int ret = 0; unsigned long age; double lat, lon, height; @@ -235,7 +234,7 @@ int verify_net_loc(struct ctrl_cmd *cmd, const char *value, void *data) if ((agestr == NULL) || (latstr == NULL) || (lonstr == NULL) || (heightstr == NULL)) - ret = 1; + return 1; age = atol(agestr); lat = atof(latstr); @@ -246,7 +245,7 @@ int verify_net_loc(struct ctrl_cmd *cmd, const char *value, void *data) if ((age == 0) || (lat < -90) || (lat > 90) || (lon < -180) || (lon > 180)) return 1; - return ret; + return 0; } CTRL_CMD_DEFINE(trx_rf_lock, "rf_locked"); -- cgit v1.2.3