From e6052c4cc756f7d3a5023a0ba57fe8d80783967c Mon Sep 17 00:00:00 2001 From: Max Date: Thu, 30 Jun 2016 10:25:49 +0200 Subject: Make random MSISDN assignment optional Previously if subscriber was automatically created it got assigned random MSISDN number. Make it optional (defaulting to previous behavior) by adding following: * new optional no-extension argument for subscriber-create-on-demand vty command * db unit tests * vty test Note: using the db made with new code might result in subscribers with empty extension. Such subscribers cannot be deleted using old code. Make sure not to mix db versions or manually fix it by editing sqlite with external program. Fixes: OS#1658 Change-Id: Ibbc2e88e4722b08854ebc631485f19ed56443cbb --- openbsc/src/libmsc/gsm_subscriber.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'openbsc/src/libmsc/gsm_subscriber.c') diff --git a/openbsc/src/libmsc/gsm_subscriber.c b/openbsc/src/libmsc/gsm_subscriber.c index 1dc2cc26d..08198c765 100644 --- a/openbsc/src/libmsc/gsm_subscriber.c +++ b/openbsc/src/libmsc/gsm_subscriber.c @@ -26,6 +26,7 @@ #include #include #include +#include #include @@ -203,10 +204,12 @@ void subscr_remove_request(struct subscr_request *request) } struct gsm_subscriber *subscr_create_subscriber(struct gsm_subscriber_group *sgrp, - const char *imsi, uint64_t smin, - uint64_t smax) + const char *imsi) { - struct gsm_subscriber *subscr = db_create_subscriber(imsi, smin, smax); + struct gsm_subscriber *subscr = db_create_subscriber(imsi, + sgrp->net->ext_min, + sgrp->net->ext_max, + sgrp->net->auto_assign_exten); if (subscr) subscr->group = sgrp; return subscr; -- cgit v1.2.3