From 3ba3cf85e1f779b3c42547df4f840d3dcbb89267 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Fri, 29 Aug 2014 08:46:05 +0200 Subject: osmux: fix unchecked return value in mgcp_parse_osmux_cid() ** CID 1232804: Unchecked return value (CHECKED_RETURN) /src/libmgcp/mgcp_protocol.c: 888 in mgcp_parse_osmux_cid() --- openbsc/src/libmgcp/mgcp_protocol.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'openbsc/src/libmgcp') diff --git a/openbsc/src/libmgcp/mgcp_protocol.c b/openbsc/src/libmgcp/mgcp_protocol.c index db8354abf..ae275a890 100644 --- a/openbsc/src/libmgcp/mgcp_protocol.c +++ b/openbsc/src/libmgcp/mgcp_protocol.c @@ -883,9 +883,11 @@ uint32_t mgcp_rtp_packet_duration(struct mgcp_endpoint *endp, static int mgcp_parse_osmux_cid(const char *line) { - uint32_t osmux_cid; + int osmux_cid; + + if (sscanf(line + 2, "Osmux: %u", &osmux_cid) != 1) + return -1; - sscanf(line + 2, "Osmux: %u", &osmux_cid); if (osmux_cid > OSMUX_CID_MAX) { LOGP(DMGCP, LOGL_ERROR, "Osmux ID too large: %u > %u\n", osmux_cid, OSMUX_CID_MAX); -- cgit v1.2.3