From 57ee78078905c7499bd4e6857f8981d22badfcac Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Sat, 20 Jun 2015 18:45:35 +0200 Subject: bts: Arfcn can never be smaller than 0 Remove the condition because it can never be true. Fixes: Coverity CID#1307793 --- openbsc/src/libbsc/bsc_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'openbsc/src/libbsc/bsc_init.c') diff --git a/openbsc/src/libbsc/bsc_init.c b/openbsc/src/libbsc/bsc_init.c index a63528c87..46d95cc1d 100644 --- a/openbsc/src/libbsc/bsc_init.c +++ b/openbsc/src/libbsc/bsc_init.c @@ -397,8 +397,7 @@ static int bootstrap_bts(struct gsm_bts *bts) } break; case GSM_BAND_900: - if (bts->c0->arfcn < 0 || - (bts->c0->arfcn > 124 && bts->c0->arfcn < 955) || + if ((bts->c0->arfcn > 124 && bts->c0->arfcn < 955) || bts->c0->arfcn > 1023) { LOGP(DNM, LOGL_ERROR, "GSM900 channel must be between 0-124, 955-1023.\n"); return -EINVAL; -- cgit v1.2.3