From abddd6aa441b85d030f0f9c12ca326cf956063fb Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Tue, 6 May 2014 06:45:30 +0200 Subject: nat/bsc: Check proto before calling ipaccess_rcvmsg_base The code in the BSC/NAT called ipaccess_rcvmsg_base without checking if the protocol is IPA. This lead the BSC to respond to SCCP messages with an "ID ACK". From a quick look neither the code of ipaccess_rcvmsg_base in OpenBSC nor the copy of libosmo-abis ever checked the protocol header. So this code has been wrong since initially being created in 2010. --- openbsc/include/openbsc/ipaccess.h | 1 - 1 file changed, 1 deletion(-) (limited to 'openbsc/include/openbsc') diff --git a/openbsc/include/openbsc/ipaccess.h b/openbsc/include/openbsc/ipaccess.h index a25a348b6..bc1fa6ed4 100644 --- a/openbsc/include/openbsc/ipaccess.h +++ b/openbsc/include/openbsc/ipaccess.h @@ -30,7 +30,6 @@ struct ipac_ext_lac_cmd { /* * methods for parsing and sending a message */ -int ipaccess_rcvmsg_base(struct msgb *msg, struct osmo_fd *bfd); void ipaccess_prepend_header(struct msgb *msg, int proto); void ipaccess_prepend_header_ext(struct msgb *msg, int proto); int ipaccess_send_pong(int fd); -- cgit v1.2.3