From dd49beebb179d12fd156d22337d645340609addc Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Tue, 21 Jun 2016 20:53:27 +0200 Subject: err log: tweak dyn pdch ack error logging Rather use gsm_lchan_name(). Change-Id: I0334484eaa6a2c0f25925042c9c3c1a4e3e78ca4 --- openbsc/src/libbsc/abis_rsl.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/openbsc/src/libbsc/abis_rsl.c b/openbsc/src/libbsc/abis_rsl.c index a141a4b06..9f7628090 100644 --- a/openbsc/src/libbsc/abis_rsl.c +++ b/openbsc/src/libbsc/abis_rsl.c @@ -1233,18 +1233,18 @@ static bool lchan_may_change_pdch(struct gsm_lchan *lchan, bool pdch_act) OSMO_ASSERT(ts->trx->bts); if (lchan->ts->pchan != GSM_PCHAN_TCH_F_PDCH) { - LOGP(DRSL, LOGL_ERROR, "(bts %u, trx %u, ts %u, pchan %s)" - " Rx PDCH %s ACK for channel that is no TCH/F_PDCH\n", - ts->trx->bts->nr, ts->trx->nr, ts->nr, + LOGP(DRSL, LOGL_ERROR, "%s pchan=%s Rx PDCH %s ACK" + " for channel that is no TCH/F_PDCH\n", + gsm_lchan_name(lchan), gsm_pchan_name(ts->pchan), pdch_act? "ACT" : "DEACT"); return false; } if (lchan->state != LCHAN_S_NONE) { - LOGP(DRSL, LOGL_ERROR, "(bts %u, trx %u, ts %u, pchan %s)" - " Rx PDCH %s ACK in unexpected state: %s\n", - ts->trx->bts->nr, ts->trx->nr, ts->nr, + LOGP(DRSL, LOGL_ERROR, "%s pchan=%s Rx PDCH %s ACK" + " in unexpected state: %s\n", + gsm_lchan_name(lchan), gsm_pchan_name(ts->pchan), pdch_act? "ACT" : "DEACT", gsm_lchans_name(lchan->state)); -- cgit v1.2.3