From 4b940126a3132ac6d6da4194229f2b8cb642c2ec Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Tue, 22 Mar 2016 19:26:34 +0100 Subject: comments about incomplete MM ciphering --- openbsc/src/libmsc/gsm_04_08.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c index 801931f74..9d53eb629 100644 --- a/openbsc/src/libmsc/gsm_04_08.c +++ b/openbsc/src/libmsc/gsm_04_08.c @@ -1152,8 +1152,13 @@ static int gsm48_rx_mm_auth_resp(struct gsm_subscriber_connection *conn, struct DEBUGPC(DMM, "OK\n"); + /* TODO separate enable flags and/or A5 algos for auth and encryption */ if (net->a5_encryption) /* Start ciphering */ + /* TODO gsm0808_cipher_mode() is still a dummy, and no code + * to receive a Ciphering Mode Complete exists in the MSC. + * As soon as such a receiver exists, it must call + * iu_tx_sec_mode_cmd() as below. */ return gsm0808_cipher_mode(conn, net->a5_encryption, conn->sec_operation->atuple.kc, 8, 0); -- cgit v1.2.1