From 3d7230b2a2bb5e49192ee316418b0e1572882555 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Fri, 25 Nov 2016 23:59:43 +0100 Subject: libmsc/db: Prevent subscr->extension without NULL termination Change-Id: Ic1ae7b2d9dde8dab8f7795e5baa8918424f5f393 Fixes: Coverity CID 57622 --- openbsc/src/libmsc/db.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/openbsc/src/libmsc/db.c b/openbsc/src/libmsc/db.c index 5cccb3280..c212fcd28 100644 --- a/openbsc/src/libmsc/db.c +++ b/openbsc/src/libmsc/db.c @@ -837,8 +837,10 @@ static void db_set_from_query(struct gsm_subscriber *subscr, dbi_conn result) } string = dbi_result_get_string(result, "extension"); - if (string) + if (string) { strncpy(subscr->extension, string, GSM_EXTENSION_LENGTH); + subscr->extension[sizeof(subscr->extension)-1] = '\0'; + } subscr->lac = dbi_result_get_ulonglong(result, "lac"); -- cgit v1.2.3