From 03461ecaa1617448a7b4de8a2182137414da4b78 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Tue, 11 Oct 2016 00:50:05 +0200 Subject: IuCS: don't remove Iu conn until release FIXME Don't remove the gsm_subscriber_connection without an Iu Release. The 2G paradigm is to close a subscriber connection as soon as nothing else is pending. In 3G however, the conn is often discarded even though the IuCS stays open and valid, which confuses the situation: before the UE releases a bit later, we would try to page the subscriber unsuccessfully, because the UE expects to already be connected. To first fix the discrepancy of Iu vs. subscr release, never discard gsm_subscriber_connections when msc_release_connection() is called. This creates a "lazy" CN that keeps connections open as long as the UE will tolerate. It is really fast in sending many SMS in close succession, but is certainly a bad CN design choice: we should rather stay lean on connections. A subsequent commit will change this, but I decided to keep this commit as a reference, for when we'd like to test situations that should re-use an established connection. Change-Id: I012378cfa432d791146db387554ec1909de05297 --- openbsc/src/libmsc/gsm_04_08.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c index e948d7b8f..e1e3107de 100644 --- a/openbsc/src/libmsc/gsm_04_08.c +++ b/openbsc/src/libmsc/gsm_04_08.c @@ -811,6 +811,12 @@ static int gsm48_rx_mm_imsi_detach_ind(struct gsm_subscriber_connection *conn, s osmo_signal_dispatch(SS_SUBSCR, S_SUBSCR_DETACHED, vsub); vlr_subscr_put(vsub); +#if 0 + /* FIXME: for IuCS, always wait until the UE releases. */ + if (conn->via_ran == RAN_UTRAN_IU) + return 0; +#endif + msc_close_connection(conn); return 0; } -- cgit v1.2.3