AgeCommit message (Collapse)AuthorFilesLines
2011-07-18misc: Remove the osmocom/core/process.h includeHolger Hans Peter Freyther5-5/+0
The osmo_daemonize moved from process.h to application.h (that is already included), remove the process.h include.
2011-07-16ipaccess-firmware: Fix dumping the wrong header fieldsHolger Hans Peter Freyther1-2/+2
We want to compare the file more_magic[0] and more_magic[1] with the static more_magic array to see where the difference is. src/ipaccess/ipaccess-firmware.c +64 ipaccess_analyze_file(26) warn: buffer overflow 'firmware_header->more_magic' 2 <= 2 src/ipaccess/ipaccess-firmware.c +64 ipaccess_analyze_file(26) warn: buffer overflow 'firmware_header->more_magic' 2 <= 3
2011-07-16sgsn_libgtp: remove bogus unreached second return statementHarald Welte1-2/+0
found by Smatch
2011-07-16sgsn_main: add comment about exit statement never reachedHarald Welte1-0/+1
2011-07-16gprs_gmm: ctx cannot be null, so remove checkHarald Welte1-1/+1
Detected by Smatch: /home/laforge/projects/git/openbsc/openbsc/src/gprs/gprs_gmm.c +757 gsm48_rx_gmm_att_req(133) warn: variable dereferenced before check 'ctx'
2011-07-16gprs_bssgp_util.c: orig_msg == NULL is not supportedHarald Welte1-3/+2
we need it for deriving the NSEI anyway. Detected by Smatch
2011-07-16ipaccess-proxy: use ANSI function declarations (void)Harald Welte1-2/+2
2011-07-16ipaccess-proxy: fix array bounds problemHarald Welte1-2/+2
detected by Smatch: /home/laforge/projects/git/openbsc/openbsc/src/ipaccess/ipaccess-proxy.c +173 store_idtags(14) error: buffer overflow 'ipbc->id_tags' 255 <= 255 /home/laforge/projects/git/openbsc/openbsc/src/ipaccess/ipaccess-proxy.c +173 store_idtags(14) error: buffer overflow 'ipbc->id_tags' 255 <= 255 /home/laforge/projects/git/openbsc/openbsc/src/ipaccess/ipaccess-proxy.c +175 store_idtags(16) error: buffer overflow 'ipbc->id_tags' 255 <= 255 /home/laforge/projects/git/openbsc/openbsc/src/ipaccess/ipaccess-proxy.c +178 store_idtags(19) error: buffer overflow 'ipbc->id_tags' 255 <= 255 /home/laforge/projects/git/openbsc/openbsc/src/ipaccess/ipaccess-proxy.c +500 ipaccess_rcvmsg(66) error: buffer overflow 'ipbc->rsl_conn' 4 <= 4 /home/laforge/projects/git/openbsc/openbsc/src/ipaccess/ipaccess-proxy.c +504 ipaccess_rcvmsg(70) error: buffer overflow 'ipbc->bsc_rsl_conn' 4 <= 4
2011-07-16bs11_config: fix array bounds problem by using value_stringHarald Welte1-20/+18
Detected by Smatch: /home/laforge/projects/git/openbsc/openbsc/src/utils/bs11_config.c +223 linkstate_name(5) error: buffer overflow 'bs11_link_state' 3 <= 3 /home/laforge/projects/git/openbsc/openbsc/src/utils/bs11_config.c +240 mbccu_load_name(5) error: buffer overflow 'mbccu_load' 6 <= 6 /home/laforge/projects/git/openbsc/openbsc/src/utils/bs11_config.c +905 main(34) info: ignoring unreachable code.
2011-07-16gsm_04_11: use 'unsigned int sms_alphabet' to include 0xffffffffHarald Welte1-1/+2
Detected by Smatch
2011-07-16db: use ANSI (void) function declarationsHarald Welte2-4/+4
2011-07-16db: fix Smatch warningsHarald Welte1-5/+3
/home/laforge/projects/git/openbsc/openbsc/src/libmsc/db.c +254 db_fini(6) info: redundant null check on db_dirname calling free() /home/laforge/projects/git/openbsc/openbsc/src/libmsc/db.c +256 db_fini(8) info: redundant null check on db_basename calling free() /home/laforge/projects/git/openbsc/openbsc/src/libmsc/db.c +280 db_create_subscriber(20) warn: variable dereferenced before check 'subscr'
2011-07-16bsc_vty: Fix some Smatch warningsHarald Welte1-4/+7
/home/laforge/projects/git/openbsc/openbsc/src/libbsc/bsc_vty.c +1062 show_e1ts(25) warn: variable dereferenced before check 'line' /home/laforge/projects/git/openbsc/openbsc/src/libbsc/bsc_vty.c +1075 show_e1ts(38) warn: buffer overflow 'line->ts' 32 <= 32
2011-07-16abis_nm: fix signedness error (uint8_t len cannot be negative)Harald Welte1-1/+1
Detected by Smatch
2011-07-13[bsc-nat] ctrlif: use llist_entry() macro and fix overly-long linesHarald Welte1-4/+9
2011-07-13[bsc-nat] ctrlif: save ourselves one level of indentationHarald Welte1-32/+30
2011-07-13[bsc-nat] ctrlif: use the 'err' label consistentlyHarald Welte1-4/+2
and propagate -ENOMEM in case we have no memory
2011-07-13bsc-nat: ctrlif: split out handle_ctrlif_msg() from ipaccess_bsc_read_cb()Harald Welte1-66/+71
We want to avoid spaghetti code by creating smaller functions, which also helps with the line lengths / indentation levels.
2011-07-13controlif: declare controlif_setup() in control_cmd.hHarald Welte4-6/+3
this avoids us to copy+paste external declarations over all 'main' files.
2011-07-13controlif: Adapt to minor data structure change regarding nm_stateHarald Welte1-1/+1
This was required due to master diverging from where controlif had last branched off.
2011-07-13Merge branch 'daniel_ctrlif'Harald Welte17-2/+1899
2011-07-13nat: Use libctrl and add command forwarding to osmo-bscDaniel Willmann4-0/+303
Passes commands beginning with "bsc.<num>" to the bsc that is responsible for LAC <num>.
2011-07-13libctrl: Add ctrl_cmd_cpy() to copy a commandDaniel Willmann2-0/+37
2011-07-13osmo_bsc: Add some libctrl commandsDaniel Willmann1-0/+164
* net.location to get/set the geographical location of the network format is <tstamp>,<lat>,<lon>,<height> * per trx rf_locked command (net.bts0.trx0.rf_locked) * network-wide rf_locked command (net.rf_locked)
2011-07-13osmo_bsc: Use libctrl, handle ctrl cmds on port 4249 or from the natDaniel Willmann3-0/+39
This patch initializes libctrl to listen for connections on port 4249. Additionally, control messages arriving from the nat will also be processed.
2011-07-13bsc_hack: Use libctrl, listen on port 4249Daniel Willmann2-1/+6
2011-07-13libctrl: Add commands to query counters and rate_cntrDaniel Willmann1-0/+258
These commands are installed in controlif_setup. Query them like this: "rate_ctr.<interval>.<counter group>.<index>.<counter name>" for rate counters and "counter.<counter name>" for regular counters. <interval> may be either "abs" for absolute values or one or "per_{sec,min,hour,day}". It is possible to query all rate counters in a group (regardless of index) or all counters in a group and with a certain index if you omit <counter name> and <index> or just <counter name>.
2011-07-13libctrl: Add macros to help define commandsDaniel Willmann1-0/+69
2011-07-13Add libctrl, an SNMP-like control interfaceDaniel Willmann6-1/+902
In contrast to the VTY interface the control interface is meant to be used by programs. This patch adds basic support, no commands are defined.
2011-07-13Add example to communicate through the control interfaceDaniel Willmann1-0/+100
2011-07-13Add documentation for the control interface protocolDaniel Willmann1-0/+21
2011-07-12osmo-bsc: Some more logging (LOGL_INFO).Harald Welte1-0/+12
2011-07-12osmo-bsc: Add missing return statement causing CIPH MODE REJHarald Welte1-0/+2
due to a missing return statement, we ran into the 'reject' case of bssmap_handle_cipher_mode(). Due to another bug in libosmocore, the reject message was corrupted (fixed in libosmocore commit 0c83670a595a278b7d1fb7b21b2eacab84d3c031)
2011-07-11osmo_bsc_msc: use DMI consistnetly for debugging packet payloadHarald Welte1-1/+1
2011-07-11bsc/msc bssap: some logging clean-upHarald Welte1-6/+16
* the DEBUG level will print hex-dumps of messages * all other messages are INFO or higher * print human-readable name of BSSMAP message types
2011-07-11use the recently introduced gsm0808_bssmap_name() of libosmogsmHarald Welte1-2/+4
This allows human-readable printing of message types on the A interface.
2011-07-01add sample osmo-bsc configuration fileHarald Welte1-0/+131
2011-06-30misc: Link to libosmogsm after adding our static librariesHolger Hans Peter Freyther1-2/+2
GCC 4.6.0 and LD.BFD 2.21 on ARM somehow fail to resolve the dbi symbols when we have the library in front of the static libraries, move them to the back. Without this patch the tlv_def_patch symbol and the gsm48_construct_ra.
2011-06-30misc: Link to -ldbi after adding our static librariesHolger Hans Peter Freyther2-4/+4
GCC 4.6.0 and LD.BFD 2.21 on ARM somehow fail to resolve the dbi symbols when we have the library in front of the static libraries, move them to the back.
2011-06-30bsc: Require osmo-sccp 0.0.6 and update the APIHolger Hans Peter Freyther3-4/+5
2011-06-29properly reset the MO state of all MO on Abis disconnect0.9.14Harald Welte3-10/+38
When we loose the A-bis link, we should properly re-set the administrative, operational and availability state of all MOs
2011-06-29add lchan->meas for BTS side codeHarald Welte1-0/+38
TODO: move all of the BTS side per-lchan data behind a 'void *role' pointer like 'struct gsm_bts'
2011-06-27Revert "HACK: disable NM_ATTR for CELL GLOBAL ID for sysmo-bts"Harald Welte1-2/+2
This reverts commit 8b65ab9d9133efe53a058733d492ac0595040fb4, which should never have been committed to master. In fact, it is not even needed anymore with recent osmo-bts code.
2011-06-27update debug_test with logging system changesHarald Welte1-1/+1
Thanks to Konrad Meier
2011-06-26make channel_test build againHarald Welte1-1/+1
2011-06-26move gsm0502_calc_paging_group() to libosmocoreHarald Welte2-18/+1
2011-06-26generalize function for calculation of the paging groupHarald Welte1-7/+10
2011-06-26move gsm 05.02 related calculations into libosmocoreHarald Welte3-28/+3
2011-06-26use new gsm48_number_of_paging_subchannels from libosmocoreHarald Welte3-17/+4
2011-06-26system information related bits for osmo-btsHarald Welte1-1/+9