AgeCommit message (Collapse)AuthorFilesLines
2016-06-29debian: New release for mgcp osmux feature negotiationusers/daniel/osmux-issuesDaniel Willmann1-2/+9
Change-Id: I3dc2b60c5acf5b35eb082f88abe464864f0f7e19
2016-06-29osmux: Add negotiation state so race conditions can't disable osmuxDaniel Willmann3-5/+7
Change-Id: Id624b0279aee5e2412059a10296ce7896e2d4628
2016-05-26debian: Make a new release for better memory mgmtzecke/stable/0.15Holger Hans Peter Freyther1-0/+6
Puts the copied IMSI into the right context to be released at the SCCP connection level. Change-Id: Ibbe8fc969393e503780933a962ad35dc215cb5e7
2016-05-26filter/nat: Fix the context for the imsi assignmentHolger Hans Peter Freyther2-1/+4
In c09f8a3b7fb94ccef41e33c32bfe2bff1ffe0e44 as part of a cleanup I accidently changed the talloc context from "con" to "bsc". The issue occurred at an earlier commit when assigning req.ctx to the "wrong" context. The allocation needs to be scoped by the struct nat_sccp_connection and not the connection from BSC to NAT. Before we have a nat_sccp_connection we scope the copied imsi to the bsc_connection and then steal it, but for the identity resp we will always have a nat_sccp_connection and can already use the right context. [Backported from master] Change-Id: I53789aad2809e19338ad3b2deb72c4757e7bd524 Related: OS#1733 Reviewed-on: https://gerrit.osmocom.org/102 Tested-by: Jenkins Builder Reviewed-by: Harald Welte <laforge@gnumonks.org> Reviewed-by: daniel <dwillmann@sysmocom.de> Reviewed-by: Holger Freyther <holger@freyther.de>
2015-12-17debian: New release with cherry-pick of gbproxy fixzecke/release/openbsc-0.15.0+z6shared/packages/testingHolger Hans Peter Freyther1-0/+6
2015-12-17gbproxy: Fix stored msgbs in gbproxy_flush_stored_messagesJacob Erlbeck1-1/+1
Currently the last message received is patched with the meta information of each stored message. This can lead to invalid memory accesses. This commit replaces msg by stored_msg in the call to gbproxy_patch_bssgp. Note that the fix has not been validated by unit tests yet. Addresses: Program received signal SIGSEGV, Segmentation fault. #0 memmove () at ../sysdeps/i386/i686/memmove.S:68 #1 0x08052ee9 in gprs_msgb_resize_area at gprs_utils.c:99 #2 0x0804f4de in gbproxy_patch_apn_ie at gb_proxy_patch.c:108 #3 0x0804f7cd in gbproxy_patch_llc at gb_proxy_patch.c:253 #4 0x0804f9cb in gbproxy_patch_bssgp at gb_proxy_patch.c:348 #5 0x0804abf5 in gbproxy_flush_stored_messages at gb_proxy.c:347 Ticket: OW#1550 Sponsored-by: On-Waves ehf
2015-11-30debian: Make new release 5e95a411946ba3c520f048c07f8fdc3dff26d564Holger Hans Peter Freyther1-0/+7
2015-11-30New OpenBSC release based on 98fa3dc1c655033b31d90ed051cfa9144e30248cHolger Hans Peter Freyther1-0/+7
2015-11-30New OpenBSC releaseHolger Hans Peter Freyther1-0/+9
2015-11-30Make a new release from a777c9ee3d4e433c713f7a5c346519aa0321f096Holger Hans Peter Freyther1-0/+7
2015-11-30New release based on fa07b489dc3e14579b34365c0a0f1b5d5a70138fHolger Hans Peter Freyther1-2/+10
2015-11-30debian: Make a new release againHolger Hans Peter Freyther1-2/+9
2015-11-30debian: New releaseHolger Hans Peter Freyther1-0/+6
2015-11-30debian: Build new packageHolger Hans Peter Freyther1-1/+7
2015-11-30debian: Add the new c-ares dependency for the SGSNHolger Hans Peter Freyther1-1/+2
2015-11-30debian: New release with new NAT commandHolger Hans Peter Freyther1-3/+13
2015-11-30debian: Build new packagesHolger Hans Peter Freyther1-1/+2
2015-11-30sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)Jacob Erlbeck1-9/+20
Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf
2015-11-30sgsn: Added TODOs (TODO)Jacob Erlbeck1-0/+6
TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf
2015-11-30sgsn: Add logging to connect_timer_cb (TODO)Jacob Erlbeck1-0/+3
TODO: - LOGLevel ? Sponsored-by: On-Waves ehf
2015-11-30gtphub: add to osmoappdesc.pyNeels Hofmeyr1-2/+4
Sponsored-by: On-Waves ehi
2015-11-30gtphub: add to debian buildNeels Hofmeyr7-0/+192
By the example of osmo-sgsn, package osmo-gtphub for debian. Sponsored-by: On-Waves ehi
2015-11-29gtphub_test: build only when c-ares and gtp are present.Neels Hofmeyr1-0/+4
2015-11-26gtphub: remove another obsolete comment.Neels Hofmeyr1-69/+0
2015-11-24gtphub: add enable_gtphub_test to atlocal.in.Neels Hofmeyr1-0/+1
This line was missing, I noticed only now.
2015-11-24gtphub: fix ares segfault: add missing initialization.Neels Hofmeyr1-0/+2
The struct gtphub_resolved_ggsn was not initialized properly, so that adding it to a list caused a segmentation fault.
2015-11-24gtphub: lose obsolete comment.Neels Hofmeyr1-2/+0
The del_cb is now also used for ares (GGSN resolution) timeouts, and expiry is anyway separated from nr_map, so this comment is void. Sponsored-by: On-Waves ehi
2015-11-21tests/smpp: Fix linking orderHarald Welte1-2/+3
At least when using system-wide libtalloc, the LIBOSMOCORE_LIBS must come last, after the static libraries under libcommon.
2015-11-21Fix compilation with no libc-ares present on the systemHarald Welte2-3/+5
This build failure was introduced with the OAP and gtphub changes.
2015-11-20gtp: Fix Makefile.am so maybe distcheck is now going to workHolger Hans Peter Freyther1-1/+1
2015-11-20vty: Print NCC/BCC and not just integer value of BSICHarald Welte1-1/+2
2015-11-20Fix TSC/BSIC handling bug and remove bts->tscHarald Welte7-37/+15
This fixes a bug in the following circumstances: * BSIC is set to 0 in the config file * No TSC is explicitly specified at the BST level in the config file In this case, we ended up using BSIC=0 and TSC=7, as TSC=7 is our default initialization value. The TSC of the CCCH/BCCH must always be the BCC, which is the lower 3 bits of the BSIC. Having configuration options for both the BSIC _and_ the TSC at the BTS level therefore makes no sense, as it only adds ways in which users can configure non-oprational configurations. So we remove the bts->tsc member, and keep only the ts->tsc members that allow us to configure a timeslot-specific TSC that's different from the BTS TSC (= BCC).
2015-11-20oap and gtphub tests must only be compiled of LIBGTP is present!Harald Welte1-2/+2
2015-11-20Depend on libgtp >= 0.92, as previous versions don't have gtpie.h installedHarald Welte1-1/+1
this fixes compilation for people having older gtp libraries installed.
2015-11-20meas_db.c: fix compiler warningsHarald Welte1-0/+1
s_db.c: In function ‘_insert_ud’: meas_db.c:65:6: warning: implicit declaration of function ‘rxlev2dbm’ [-Wimplicit-function-declaration] rxlev2dbm(ud->full.rx_lev))); ^
2015-11-20gtphub: fix echo reply to SGSNs: wrong fd. Add test.Neels Hofmeyr2-16/+62
The actual fix is just one character, but also add a regression test against this, on both CTRL and USER plane.
2015-11-18gtphub: fix three oversights (thanks to coverity).Neels Hofmeyr1-5/+3
- an unnecessary if-not-NULL check (1339764); - a missing nul termination safety net (1339768); - a typo resulting in the wrong proxy being logged (1339767). Sponsored-by: On-Waves ehi
2015-11-18gtphub: fix fatal log msg for SGSN proxy.Neels Hofmeyr1-1/+1
While reworking the logging, a stray comma found its way into the code. Fixes coverity 1339765. Sponsored-by: On-Waves ehi
2015-11-18gtphub: fix gtphub_read() semantics.Neels Hofmeyr1-9/+7
gtphub always wants to know the sender, hence make the from_addr pointer mandatory. Fixes two coverity complaints (1339766, 1339764). Sponsored-by: On-Waves ehi
2015-11-18fix build: remove obsolete gtphub EXTRA_DIST.Neels Hofmeyr1-4/+1
Sponsored-by: On-Waves ehi
2015-11-16gtphub: cosmetic: break long lines.Neels Hofmeyr4-124/+201
Fit most of the code in 80 chars width. Some instances still leak past 80 characters because of long function names, inline comments or the like, "the exception proves the rule." Sponsored-by: On-Waves ehi
2015-11-16gtphub: review log levels, add level arg to LOG().Neels Hofmeyr1-141/+133
For maintenance, it is convenient to have the log level explicit at each log statement. Tweak some log levels / message formatting while at it. Sponsored-by: On-Waves ehi
2015-11-16gtphub: add logging labels to bind struct.Neels Hofmeyr2-1/+9
Allow logging the plane (Ctrl/User) and side (SGSN/GGSN) in functions that only have a gtphub_bind* to work with, by adding a constant label to each bind. Sponsored-by: On-Waves ehi
2015-11-16gtphub: don't always try to do GGSN resolution.Neels Hofmeyr2-29/+8
If a GGSN is already known from unmapping, don't invoke a host resolution. In a live working environment, it wouldn't hurt, because the lookups would mostly return from the cache. But in a testing environment without a name server, it barfs on every packet. Sponsored-by: On-Waves ehi
2015-11-16gtphub: fix numerous segfaults, and other stupidities.Neels Hofmeyr3-6/+10
Initialize llist_heads to empty (2 were missing). Move those for struct gtphub instances to gtphub_zero() (one moved, one added). In from_[gs]gsns_read_cb(), use a return type that can actually reflect negative return values. resolved_addr.buf: no need to take the address of a byte array var (cosmetic). Pass the proper user data address to sgsn_ares_query(), not the address of the pointer holding the user data address. Initialize ggsn_lookup->expiry_entry (was missing). Publish the function for that in gtphub.h so gtphub_ext.c can use it. Sponsored-by: On-Waves ehi
2015-11-16gtphub: Add logging for ares queries.Neels Hofmeyr2-15/+28
Looking for a segfault, I added a lot of logging. This may be useful for live testing ares, leaving it in there for now. Note: I still want to clean up the logging concerning log levels etc. once we're out of alpha. Sponsored-by: On-Waves ehi
2015-11-16gtphub: fix handling of sender from nonstandard port.Neels Hofmeyr1-3/+35
Allow a peer sending from an unknown port but a known address, and just create the port (and unmap the seq nr back to this port later to return the response to the sender). Only an SGSN on the Ctrl plane is allowed to make the very first contact from an unknown address. Sponsored-by: On-Waves ehi
2015-11-16gtphub: fix User plane decoding, add unit test.Neels Hofmeyr3-24/+156
Split decoding return code GTP_RC_PDU in GTP_RC_PDU_C and GTP_RC_PDU_U. Don't do IEs in GTP_RC_PDU_U. Add a unit test for User plane data, expected to fail (nonstandard port case). In gtphub_test.c, tweak logging so that it is easily visible which test produced which output. Also add the global resolved_sgsn_addr and ggsn_sender, symmetrically to resolved_ggsn_add and sgsn_sender. Sponsored-by: On-Waves ehi
2015-11-16gtphub: make test code reusable for future tests.Neels Hofmeyr3-179/+246
Generalize to make the PDP ctx message definitions and "sending" of messages from SGSN->gtphub->GGSN and back reusable in future tests. Publish gsn_addr_from_sockaddr() in gtphub.h for use in gtphub_test.c. Use an osmo_sockaddr for resolved_ggsn_addr, because one is needed for comparison in probably every future test. Add LVL2_ASSERT() to print assertion message and return instead of abort, so that functions can be called from several tests without losing the info of which test caused it from which line. Use globals for struct gtphub and time_t now, to reduce nr of args that need to be passed around when writing tests. Add a default test setup function. Sponsored-by: On-Waves ehi
2015-11-16gtphub: add/fix IMSI and APN IE error handlingNeels Hofmeyr2-22/+72
Sponsored-by: On-Waves ehi