aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2009-06-29Merge branch 'master' of gitosis@bs11-abis.gnumonks.org:openbscHarald Welte34-242/+2447
2009-06-29ipaccess-find: remove compile-time specified local ip addressHarald Welte1-5/+14
2009-06-27fix various RSL msgb memory leaks in error pathsHarald Welte2-4/+11
2009-06-27cosmetic cleanup of LOCATION UPDATE REQ print-outHarald Welte1-8/+8
2009-06-27add new DMEAS debug category for measurement reportingHarald Welte4-20/+23
disable it by default
2009-06-26make tests compile again after talloc branch changesHarald Welte3-5/+11
2009-06-26use taloc_zero() rather than talloc() and explisit memset()Harald Welte7-19/+10
2009-06-26fix two segfaultsHarald Welte1-2/+5
* when paging callback is called, we need to consider a failed paging operation (i.e. lchan == NULL) * we have to zero-initialize every transaction that is allocated
2009-06-26zero-initialize some more memory that we allocateHarald Welte2-2/+2
2009-06-26add FIXME about memory leak every time we close telnetHarald Welte1-0/+3
2009-06-26fix MNCC memory leakHarald Welte1-0/+1
after passing the mncc structure (contained in msgb) to the mncc layer, we have to release its memory. This leak was discovered as a direct result of using talloc.
2009-06-26use named variant when allocating msgb'sHarald Welte11-17/+22
when we generate a talloc report (SIGUSR1), we can now see which system allocated a given msgb, this helps memory leak debugging
2009-06-26Merge branch 'master' into tallocHarald Welte5-19/+1486
2009-06-26updated RSL wireshark patchHarald Welte1-33/+225
* parse ip.access messages with different (any) attribute order * identify RTP and RTCP streams to the RTP plugin
2009-06-26fix typosHarald Welte2-2/+2
2009-06-25add new wireshark A-bis OML dissector, incompleteHarald Welte1-0/+1463
2009-06-25enable OML dissector lookup, register ourselves as "gsm_abis_ip" dissectorHarald Welte1-13/+17
2009-06-25abis_nm.h: Fix various typosHarald Welte1-4/+4
2009-06-22Add parsing of 'L1 information' IE of MEASUREMENT RESULTHarald Welte1-2/+43
2009-06-22Add parsing of 'L1 information' IE of MEASUREMENT RESULTHarald Welte1-2/+43
2009-06-22Merge branch 'master' into tallocHarald Welte0-0/+0
2009-06-22fix various talloc / dynamic bts/trx related bugsHarald Welte2-5/+13
Prior to this patch, nanobts was not able to operate after recent changes
2009-06-21switch to dynamically allocated BTS and TRX data structuresHarald Welte10-128/+204
This makes it much easier to do run-time configuration using the vty interface.
2009-06-20fix setfault during registration of VTY TRX functionHarald Welte1-1/+1
2009-06-20introduce talloc all over OpenBSCHarald Welte20-47/+2149
2009-06-20fix setfault during registration of VTY TRX functionHarald Welte1-1/+1
2009-06-20replace 'struct gsm_attr' by 'struct tlv_parsed'Harald Welte1-7/+4
This is where we will store the 12.21 / NM attributes for the given object.
2009-06-20Introduce BS and MS power control related functionsHarald Welte6-6/+212
* add bts->band field plus corresponding VTY and commandline argument * add trx->nominal_power and trx->max_power_red fields * add rsl_chan_bs_power_ctrl() to control TRX RF power for a given TS * add rsl_chan_ms_power_ctrl() to control MS RF power for a given lchan.
2009-06-20BS11: use abis_nm_set_{bts,radio}_attr()Harald Welte1-16/+14
BS11 should only use the raw message sending function if there is no standard alternative. For TRX and BTS attributes, we have the standard variant.
2009-06-15mncc: Add IMSI to gsm_mnccAndreas Eversberg2-2/+20
This allows us to do subscriber lookups based on IMSI and e.g. establish MT calls to subscribers with no assigned extension.
2009-06-14Merge branch 'mncc-harald'Harald Welte17-446/+2817
2009-06-14Merge branch 'master' of gitosis@bs11-abis.gnumonks.org:openbscHarald Welte3-3/+3
2009-06-14Use correct cause value and cause locationAndreas Eversberg1-10/+22
Fixed indication of cause value and location. Replaced plain cause numbers by definitions from header file. diff --git a/openbsc/src/gsm_04_08.c b/openbsc/src/gsm_04_08.c index f323a2a..39e7b1f 100644 --- a/openbsc/src/gsm_04_08.c +++ b/openbsc/src/gsm_04_08.c @@ -1865,8 +1865,7 @@ int mncc_release_ind(struct gsm_network *net, struct gsm_trans *trans, memset(&rel, 0, sizeof(rel)); rel.callref = callref; - mncc_set_cause(&rel, GSM48_CAUSE_LOC_PRN_S_LU, - GSM48_CC_CAUSE_UNASSIGNED_NR); + mncc_set_cause(&rel, location, value); return mncc_recvmsg(net, trans, MNCC_REL_IND, &rel); } @@ -1879,7 +1878,9 @@ void free_trans(struct gsm_trans *trans) /* send release to L4, if callref still exists */ if (trans->callref) { /* Ressource unavailable */ - mncc_release_ind(trans->network, trans, trans->callref, 1, 47); + mncc_release_ind(trans->network, trans, trans->callref, + GSM48_CAUSE_LOC_PRN_S_LU, + GSM48_CC_CAUSE_RESOURCE_UNAVAIL); if (trans->state != GSM_CSTATE_NULL) new_cc_state(trans, GSM_CSTATE_NULL); } @@ -1960,7 +1961,7 @@ static int setup_trig_pag_evt(unsigned int hooknum, unsigned int event, subscr->extension); /* Temporarily out of order */ mncc_release_ind(transt->network, transt, transt->callref, - 1, 27); + 1, GSM48_CC_CAUSE_DEST_OOO); transt->callref = 0; free_trans(transt); break; @@ -2270,7 +2271,8 @@ static int gsm48_cc_tx_setup(struct gsm_trans *trans, void *arg) "This is not allowed!\n"); /* Temporarily out of order */ rc = mncc_release_ind(trans->network, trans, trans->callref, - 1, 47); + GSM48_CAUSE_LOC_PRN_S_LU, + GSM48_CC_CAUSE_RESOURCE_UNAVAIL); trans->callref = 0; free_trans(trans); return rc; @@ -2287,7 +2289,8 @@ static int gsm48_cc_tx_setup(struct gsm_trans *trans, void *arg) if ((trans_id_mask & 0x007f) == 0x7f) { /* no free transaction ID */ rc = mncc_release_ind(trans->network, trans, trans->callref, - 1, 47); + GSM48_CAUSE_LOC_PRN_S_LU, + GSM48_CC_CAUSE_RESOURCE_UNAVAIL); trans->callref = 0; free_trans(trans); return rc; @@ -3373,14 +3376,18 @@ int mncc_send(struct gsm_network *net, int msg_type, void *arg) "unknown callref %d\n", data->called.number, get_mncc_name(msg_type), data->callref); /* Invalid call reference */ - return mncc_release_ind(net, NULL, data->callref, 1, 81); + return mncc_release_ind(net, NULL, data->callref, + GSM48_CAUSE_LOC_PRN_S_LU, + GSM48_CC_CAUSE_INVAL_TRANS_ID); } if (!data->called.number[0] && !data->called.imsi[0]) { DEBUGP(DCC, "(bts - trx - ts - ti) " "Received '%s' from MNCC with " "no number or IMSI\n", get_mncc_name(msg_type)); /* Invalid number */ - return mncc_release_ind(net, NULL, data->callref, 1, 28); + return mncc_release_ind(net, NULL, data->callref, + GSM48_CAUSE_LOC_PRN_S_LU, + GSM48_CC_CAUSE_INV_NR_FORMAT); } /* New transaction due to setup, find subscriber */ if (data->called.number[0]) @@ -3394,7 +3401,9 @@ int mncc_send(struct gsm_network *net, int msg_type, void *arg) "unknown subscriber %s\n", data->called.number, get_mncc_name(msg_type), data->called.number); /* Unknown subscriber */ - return mncc_release_ind(net, NULL, data->callref, 1, 1); + return mncc_release_ind(net, NULL, data->callref, + GSM48_CAUSE_LOC_PRN_S_LU, + GSM48_CC_CAUSE_UNASSIGNED_NR); } /* If subscriber is not "attached" */ if (!subscr->lac) { @@ -3404,14 +3413,18 @@ int mncc_send(struct gsm_network *net, int msg_type, void *arg) get_mncc_name(msg_type), data->called.number); subscr_put(subscr); /* Temporarily out of order */ - return mncc_release_ind(net, NULL, data->callref, 1, 27); + return mncc_release_ind(net, NULL, data->callref, + GSM48_CAUSE_LOC_PRN_S_LU, + GSM48_CC_CAUSE_DEST_OOO); } /* Create transaction */ if (!(trans = calloc(1, sizeof(struct gsm_trans)))) { DEBUGP(DCC, "No memory for trans.\n"); subscr_put(subscr); /* Ressource unavailable */ - mncc_release_ind(net, NULL, data->callref, 1, 47); + mncc_release_ind(net, NULL, data->callref, + GSM48_CAUSE_LOC_PRN_S_LU, + GSM48_CC_CAUSE_RESOURCE_UNAVAIL); return -ENOMEM; } trans->callref = data->callref;
2009-06-14Fix lchan refcounting in case of IMSI DETACHAndreas Eversberg1-2/+0
Removed lchan_put() after IMSI detach function. We don't need to put lchan, because we don't hold a ressource.
2009-06-12make btstype2str return a const char* to make gcc 4.4 happyHolger Hans Peter Freyther2-2/+2
2009-06-12Merge commit 'origin/master' into mncc-haraldHarald Welte1-1/+1
2009-06-12[misc] Fix make distcheck by adding compat_af_isdn.hHolger Hans Peter Freyther1-1/+1
2009-06-12SMS: fix parsing of destination phone numberHarald Welte1-2/+3
2009-06-12Increase LCHAN_RELEASE_TIMEOUT to 10 secondsHarald Welte1-1/+1
If we release the LCHAN after the CM SERVICE ACK too early, we can no longer receive longer SMS messages... so let's increase it to 10 secs.
2009-06-1204.08: Make mncc-harald branch workHarald Welte1-2/+2
This fixes two reasons for crashes due to uninitialized memory or wrong pointer passing introduced in my own mncc modifications
2009-06-12SMS: fix parsing of destination address BCDHarald Welte1-1/+1
this bug was introduced in Andreas' MNCC patches while altering decode_bcd_number().
2009-06-12abis_nm: fix printing of ADMinistrative stateHarald Welte1-1/+1
2009-06-11use less magic numbers (04.08 CC cause values)Harald Welte3-13/+83
Introduce a gsm48_cc_cause enum and use it from gsm_04_08 and MNCC, also make sure we use gsm48_cause_loc rather than plain numbers.
2009-06-10reworked MNCC codebaseHarald Welte15-441/+2731
This is Harald's reworked MNCC base, slowly heading towards integration into master. The key changes are: * provide much more structure to the data in gsm_mncc * encode_* and decode_* functions now take a structure rather than tons of individual arguments (whose order nobody can remember) * make sure we don't have copies of the same code everywhere by introducing mncc_set_cause() and mncc_release_ind() * save horizontal screen space if possible * make sure we break lines > 80 characters
2009-06-10Merge commit 'origin/master'Harald Welte14-43/+307
2009-06-10[pcap] Write incoming packages without the extra mISDN headerAndreas Eversberg1-4/+7
This patch fixes the PCAP logging. If frames are received from E1 interface, an 8 byte mISDN header (MISDN_HEADER_LEN) is in front of the RSL packet. When frames are transmitted to the E1 interface, the pcap_write_packet function will get a message buffer without the mISDN header in front of the RSL packet. The pcap file was tested and the output is correct. Follow up patches should make use the msgb->l2, make the ipaccess code use the pcap writing too...
2009-06-10Handle and dispatch paging requests in gsm_subscriberHolger Freyther3-2/+110
Implement subscr_get_channel and subscr_put_channel to a degree that SMS Submit and phone call scheduled at the same time will deliver both (one after the other).
2009-06-10[channel] Add a test case for the request foo in gsm_subscriber.cHolger Hans Peter Freyther4-1/+88
This is simulating a successfull request and is causing a segfault. The test is done with a "mock object" in this case a minimalistic paging implementation which is enough to show the crash. Compare that the callback data is supposed to be the same....
2009-06-10Proposal for a "channel request" interface...Holger Freyther5-4/+21
Reuqests for a subscriber a stored within the gsm_subscriber datastructure and it will keep track how many channels are allocated for this user and of which type to decide on policy... e.g. attempt to submit SMS during a phone call and not doing paging but a simple (immediate) assignment of the channel...
2009-06-10[paging] Unbreak breakge when moving things into paging.cHolger Hans Peter Freyther1-1/+4
By calling _paging_request_stop with NULL for the lchan we have never used the paging complete callback... I didn't spot that when moving the code over and thought it is a great simplification to not call paging_request_stop first and then loop... *sigh* restore the old behaviour. Call the callback first and then free the requests.