summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-08-24fixup for: fix handover (signalling only) and add VTX command to triggerneels/aoipPhilipp Maier1-21/+21
2017-08-24osmo-bsc: fix handover (signalling only) and add VTX command to triggerPhilipp Maier3-2/+90
Add VTY commands to trigger a handover of an lchan/subscriber connection. Fix assertion problem / crash
2017-08-24osmo-msc: cleanup ss7_setup()Philipp Maier1-44/+65
2017-08-23fix typoaoipPhilipp Maier1-1/+1
2017-08-23fixup: fix possible null pointer derefPhilipp Maier1-1/+6
Check for nullpointer - just to be sure, there was no crash at this point.
2017-08-23cosmetic: fix ugly variable namingPhilipp Maier1-8/+8
2017-08-23osmo-bsc: fix (null) string in VTY configPhilipp Maier2-7/+12
When writing the config file the options bsc-addr, and msc-addr, a (null) string is written to the config file, which prevents the config file from reading it back. memorize the string names given to bsc-addr and msc-addr and write them back, also check if the strings are NULL in case the user did not set any names.
2017-08-23osmo-bsc: pointcodes in human readable formPhilipp Maier2-14/+39
use osmo_sccp_addr_name() instead of osmo_sccp_addr_dump()
2017-08-23osmo-msc: point codes in human readable formPhilipp Maier2-12/+38
use osmo_sccp_addr_name() instead of osmo_sccp_addr_dump()
2017-08-23osmo-bsc: cleanup osmo_bsc_sigtran_init()Philipp Maier1-39/+76
2017-08-22fix msc_vlr tests after libosmocore uses localtime for SMSNeels Hofmeyr1-2/+2
libosmocore change-id I4efdb1eaae43aced33961b64d4f14b0040321c10 changes the gsm340_gen_scts() from gmtime to localtime, meaning that by feeding a mere zero as timestamp, we get different results depending on the local machine's timezone setting. Instead of calling gsm340_gen_scts() with zero, simply write a bunch of bytes as time so that the tests get identical SMS bytes every time. Change-Id: I8a980535ac3e538676ad23d2eccc368bb8b57759
2017-08-09fixup: osmo_ss7_vty_init_asp() instead of osmo_ss7_vty_init_sg()Philipp Maier2-6/+2
2017-08-09fixup for: mgcp: add VTY Option to force-realloc endpointsPhilipp Maier1-1/+1
2017-08-09osmo-bsc: make use of osmo_sccp_addr_set_ssn()Philipp Maier1-2/+1
libosmo-sccp offers a function to set the SSN. Make use of this function instead of manipulating the struct directlry
2017-08-09bsc/msc: fixup compiler issuesPhilipp Maier2-2/+6
libosmo-sccp function osmo_ss7_vty_init_sg() now requires a talloc context as parameter. Note: It should not _asp() rather then _sg(). However, we can not switch now, because then we will miss the vtx commands that configure the default route. Since the default route is the only valid route for application server processes, we need to fix this in the simple client, so that this command is no longer needed, when configuring the as. Also the VTX write functions of libosmo-sccp need to be fixed first.
2017-08-08osmo-bsc: full auto configuration for SS7/CS7Philipp Maier1-20/+44
If invalid addresses, or a missing CS7 instance is detected during startup, the BSC will assume safe defaults. The defaults picked are complementary to osmo-msc, so in case the user just wants to run the osmo-msc and osmo-bsc + the STP on one machine, no CS7 configuration is needed at all.
2017-08-08mgcp: add VTY Option to force-realloc endpointsPhilipp Maier4-4/+16
Currently the force_realloc feature is turnd on and of in a hardcoded way. This patch makes the option available via VTY.
2017-08-08osmo-bsc: fix invalid for loop headPhilipp Maier1-1/+1
2017-08-07osmo-msc: Use proper sccp instance namesPhilipp Maier1-3/+15
If the user chooses to use a single sccp instance to connect to the core network. That instance would be named OsmoMSC-Iu. This is confusing because that same connection would also serve all A interface traffic. This patch checks for the described condition and picks a more suitable name then.
2017-08-07osmo-bsc: improve checking of sccp addressesPhilipp Maier3-12/+31
Use the check functionality of libosmo-sigtran to test if the sccp addresses are smantically correct.
2017-07-31mgcp: remove proactive DLCXPhilipp Maier2-13/+2
To prevent a situation where one ore more seized enpoints stay seized after an MSC crash (information loss, endpoints can not be released) we send a DLCX command before making new connections on the MGCP-GW. This method is loud and hackish. Remove all functionality that sends a DLCX before making a new connection. Enable force_realloc functionality in the MGCP code in order to have seized enpoints automatically released on new connections, in case they are seized
2017-07-22MSC,SGSN: use OSMO_GSUP_PORT == 4222 instead of 2222Neels Hofmeyr3-2/+6
In SGSN, actually place the port in the SGSN config by default, so that the gsup port may now be omitted in the VTY config (the IP address suffices). Adjust the osmo-sgsn.cfg example. Depends: I4222e21686c823985be8ff1f16b1182be8ad6175 (libosmocore) Change-Id: I50f2040e2eb0baacb43849e93cfed10cbc2fc156
2017-07-22msc_vlr_tests: properly check BSSAP Clear and Iu ReleaseNeels Hofmeyr20-183/+412
Change-Id: Ice8125decc1a663d95ae70418e151bff559b983b
2017-07-22cosmetic: msc_vlr_tests: better place clear_cmd wrap, adjust printed msgNeels Hofmeyr1-6/+11
Change-Id: Iec6f03f97803b2604f0094260cba256e72ee67bd
2017-07-22msc_vlr_test_gsm_ciph: remove dead codeNeels Hofmeyr1-618/+0
These tests have moved to different .c files, are no longer needed here. Change-Id: Ifec8670d9a4a571c858644af9b9308b10b2a7291
2017-07-22fix release upon IMSI DetachNeels Hofmeyr11-37/+161
In case of an IMSI Detach, we don't have a conn_fsm, yet we still need to send release messages. Hence directly release the conn in msc_subscr_conn_close() when there is no conn_fsm present. Move the conn release actions from the conn_fsm cleanup function to new function msc_subscr_conn_release_all(). From the FSM cleanup, call msc_subscr_conn_close(), and invoke msc_subscr_conn_release_all() from there. Document msc_subscr_conn_close() behavior. Change-Id: Ied6981099605ad803f8ffed38f23ed8203a97727
2017-07-22cosmetic: add debug log to msc_subscr_conn_close()Neels Hofmeyr7-3/+35
Adjust test expectations. Note: this marks all the places where we are so far failing to send a Clear/Release, where during an IMSI Detach the log now says "no conn fsm, ignore". In msc_vlr_test_reject_concurrency, the places are marked "already in release" because these tests for simplicity have a rather peculiar sequence of sending an IMSI Detach right after a CM Service Request, on an open connection. Change-Id: I1c4dc4e5afce3bcb98237e3506300c78d7e4584f
2017-07-22cosmetic: tweak IMSI Detach log outputNeels Hofmeyr7-22/+21
Match the log message for known subscriber to the one for unknown subscriber. Change-Id: I73871089036c9fd301e818eaaf48142aaf295d09
2017-07-22msc_vlr_tests: add missing wrap for iu_tx_release()Neels Hofmeyr3-0/+12
It seems merely luck that the tests worked so far without this wrap. Adjust test logs now indicating where we actually send an Iu Release -- and leaving gaping holes where we don't. To be fixed in subsequent commit. Change-Id: Icf8b0b4acd8774c72cff6fdba0ff549308fc506f
2017-07-22cosmetic: add info log for Iu Release txNeels Hofmeyr1-0/+3
Change-Id: Ia64bc937d7f37ef6209efbdf884de61008f8816d
2017-07-22cosmetic: remove obsolete commentNeels Hofmeyr1-2/+1
Change-Id: Ie60e00e07b2129ac4bb3cac94921bf3c8d9cd861
2017-07-22fix handling of paging response: use conn->lacNeels Hofmeyr1-1/+1
Change-Id: Ieba69e4014213b18c18282dd724e202cce85a047
2017-07-22gsm04_08.c patches from neels (remove when committed properly)Philipp Maier1-14/+14
0001-imsi-detach-improve-error-logging.patch 0002-imsi-detach-always-close-connection-explicitly.patch
2017-07-22a-iface: move clear command to subscriber_conn.cPhilipp Maier11-178/+149
The clear command is currently triggered from the wrong place. This is a fixup that corrects that. However, it will introduce another problem: The clear command is not sent on detach. Adjust test expectations. Change-Id: Ia27d7e94cb11adf351457b3b0e98a5c9d5070fbf
2017-07-22vty: Fixup sccp/ss7 configurationPhilipp Maier3-63/+32
The sccp/ss7 configuration is now fixed. The cs7 instance id is implicitly detected from the bsc_addr or the msc_addr. Depending on what is listed last. (I am not sure if that is wise, maybe we should only use the local/bsc address to do the lookup). Remove cs7-instance vty command Modify VTY commands, so that the fixed API is used Set msc->a.cs7_instance from the VTY to when msc/bsc addr is parsed Fix the initalization to use osmo_sccp_simple_client_on_ss7_id() and pass the cs7-instance id we determined from the vty. The whole thing is not waterproof yet. We are still not at the point where we allow to leave the local address out. This would be fine, but when it is left out, the only way to determine the cs7 instance is to use the msc_addr then. We also might want to make sure to reach a state where all cs7 related config may be left out (like with the MSC)
2017-07-22fixup for: mgcp: display properly mgcp-messages in logPhilipp Maier1-0/+3
2017-07-22msc-vty-completePhilipp Maier3-11/+87
2017-07-22msc_vlr: Fix tests: accomodate a_iface_tx_clear_cmd()Philipp Maier11-0/+182
msc_vlr_tests.c: wrap a_iface_tx_clear_cmd(), adjust test expectations. Change-Id: I01c099e62b3e3d74c4f567c0654e748d9d7e45d4
2017-07-14osmo_msc: only clear A-Interface connections for GSM callsPhilipp Maier1-2/+3
The clear command is sent via the A-Interface for both, A and IuCS connections. This is wrong. Only send the clear command for connections related to the A-Interface, which means only for connections where the RAN is set to GERAN
2017-07-14fixup: fix typoPhilipp Maier1-1/+1
2017-07-14mncc: make external mncc workPhilipp Maier5-91/+140
The external mncc currently does not work properly since the MNCC_RTP_CREATE commands are removed due to the MSC-Split. It is possible to operate without these commands, but then it is not possible to route the RTP streams to an outside leg. Only internal bridging is currenlty possible. This method is used when the internal MNCC is enabled. Add the missing MNCC_RTP_CREATE implementation. Add logic to keep the old bridging mode working.
2017-07-13mgcp: display properly mgcp-messages in logPhilipp Maier1-1/+40
The generated mgcp messages are not displayed properly (stray newlines). Also, the messages we receive are not displayed at all. Display generated and received messages in logtext, reformat the strings properly so that the logtext does not get messed up
2017-07-10fixup for: a_iface: fix missing clear commandPhilipp Maier1-1/+3
2017-07-10cosmetic: tweak error log in osmo_bsc_sigtran_init()Neels Hofmeyr1-2/+4
Change-Id: Iec3dbeb0ee1421129aaf9e313d616757955bee48
2017-07-07a_iface: fix missing clear commandPhilipp Maier3-0/+16
When a subscriber connection is freed on the MSC side (the conversion is over) the MSC should send a clear command to the BSC in order to inform the BSC that the connection is over. Currently this step is missing. Instead we wait for the BSC to issue a clear request. This is not as it should be, connections should be actively cleared by the MSC. Add the missing clear command
2017-07-07a_iface: fix missing log outputPhilipp Maier2-0/+8
2017-07-07a_iface: fix missing constPhilipp Maier1-1/+1
2017-07-07a_iface: add missing staticPhilipp Maier2-2/+2
2017-07-05msc_ifaces: add checks for nullpointersPhilipp Maier1-5/+44
2017-07-05fixup: remove allocation/usage of iu struct again.Neels Hofmeyr1-9/+5
The allocation and usage of the iu struct was accidentally re-introduced into a_iface_bssap.c. Remove the allocation and the usage of iu struct. Related to: aoip: don't use iu struct: do not allocate unnecessary ue_conn_ctx