AgeCommit message (Collapse)AuthorFilesLines
2012-01-09tests: Make the test setup more abusive to fix the buildHolger Hans Peter Freyther1-5/+7
Paolo says I will need to use atconfig/atlocal, need to read up on it first though.
2012-01-06gprs: Honor GSM 04.64 8.4.2 Receipt of unacknowledged informationHolger Hans Peter Freyther8-3/+97
GSM 04.64 8.4.2 asks to ignore UI frames if the DLCI is not known, or if the "(V(UR)- 32) <= N(U) < V(UR)". E.g. if we want to have V(UR) == 511 and this frame is dropped, we would ignore N(U)'s 0 to 510. Calculate the delta. The code is based on Jonathan Santos's "LLC UI window" fix but the issue was discovered independly.
2012-01-06gprs_sgsn.h: Include timer.h for the timer structHolger Hans Peter Freyther1-0/+2
2012-01-06tests: Introduce running tests with GNU autotest in OpenBSCHolger Hans Peter Freyther14-1/+133
The quality of the tests is of different value but it is good to get started and improve from here.
2012-01-06mgcp: Print message when the test is finishedHolger Hans Peter Freyther1-2/+8
2012-01-06gsm0408: Print message when the test is doneHolger Hans Peter Freyther1-1/+2
2012-01-06db: Fix the test codeHolger Hans Peter Freyther1-14/+27
* Initialize logging * use a dummy net before calling subcr_put as the keep in ram option is going to be set.
2012-01-06channel: Make the test not crash again.Holger Hans Peter Freyther1-4/+15
* Initialize logging * The callback expects NULL or a subscriber connection
2012-01-06nat: Log test output stdout using printf in prep for GNU autotestHolger Hans Peter Freyther1-78/+97
2011-12-27bsc: Assume assignment_complete/assignment_fail is setHolger Hans Peter Freyther2-5/+30
The osmo-nitb application sometimes crashes because the BSC API is doing an assignment underneath which is not handled by the code, add dumy handlers to not crash, the right thing to do is to change MNCC to have an assignment that can succeed/fail. The keyword to look for is MNCC_LCHAN_MODIFY and mncc_sock should wait for an ack/nack but right now the call just continues.
2011-12-24RSL: Nokia BTS reports TA in quarter-bits, not full bits.Andreas Eversberg1-2/+3
We need to compensate accordingly...
2011-12-16RSL: BS-11 reports TA in quarter-bits, not full bits.Andreas Eversberg1-4/+11
We need to compensate accordingly...
2011-12-02Add NITZ (timezone) support as part of MM INFOGus Bourg3-22/+86
The UTC offset from the operating system will be used by default to calculate the NITZ in MM INFO. However, a "timezone" vty command is added at the BTS level, allowing BTS-specific overrides, e.g. in case BTSs are distributed accross multiple timezones.
2011-11-25fix two mistakes in AM_LDFLAGSAlexander Huemer2-2/+2
2011-11-25BSSGP: Add functions required for true BSS-side BSSGP implementationHarald Welte4-13/+442
The BSS-side of BSSGP requires quite a number of additional functions for sending unidirectional messages that a SGSN never sends. This is a first step into completing the BSSGP implementation and making it ready to be used from osmo-bts and other BTS-side GPRS implementations.
2011-11-25BSSGP: add more doxygen commentsHarald Welte1-25/+29
2011-11-24GPRS: add new bssgp_create_cell_id(), opposite of bssgp_parse_cell_id()Harald Welte1-0/+12
2011-11-24GPRS NS: Add some doxygen API documentationHarald Welte2-26/+143
2011-11-13bsc_vty: Fix usage of deprecated osmo_osmo_hexdump_nospcSylvain Munaut1-1/+1
The typo was fixed upstream Signed-off-by: Sylvain Munaut <>
2011-11-13osmo_nitb: introduce --no-dbcounter command line optionHarald Welte1-2/+9
this allows us to disable writing the current rate counters to the sqlite database every 60 seconds.
2011-11-07gsm0408: Print a message when the LU is timing out.Holger Hans Peter Freyther1-0/+1
2011-11-06mncc: Introduce a hello packet that is sent to the client.Holger Hans Peter Freyther2-0/+32
Send a hello packet down to the client with the version number of the MNCC interface. The hello structure might be extended to include the endianes, size of each structure, etc.
2011-11-06sgsn: Make sure each parameter has some sort of documentationHolger Hans Peter Freyther1-5/+8
2011-11-06gb_proxy: Make sure each parameter has some sort of documentationHolger Hans Peter Freyther3-2/+7
2011-11-06mgcp: Make sure each command has some kind of online helpHolger Hans Peter Freyther1-37/+96
In this iteration I just want to make sure that each VTY command has online help. Replace "a b" with "a-b" if there is no "a c" with b!=c. This config should gain some more sanity and consistency, this will happen in another iteration.
2011-11-06mncc: Remove FIXME about queuing messagesHolger Hans Peter Freyther1-2/+0
mncc_sock_from_cc will discard the messages when the fd has been set to -1.
2011-11-06mncc: Address the fixme and put the mncc_sock_state in gsm_networkHolger Hans Peter Freyther2-11/+6
Remove the unused mncc_sock_write_pending, switch over from the static s_state to net->mncc_state.
2011-11-06misc: Fix typo...'teh' -> 'the'Holger Hans Peter Freyther1-1/+1
2011-11-02nokia: Use a longer T200 because RSL link can be pretty slow after a resetAndreas.Eversberg1-2/+4
Written-by: Andreas Eversberg <> Signed-off-by: Sylvain Munaut <>
2011-10-18build: Update to use libgtp.pc rather than manual detectionSylvain Munaut1-4/+4
Signed-off-by: Sylvain Munaut <>
2011-10-18libbsc/nokia_site: Increase reset timer to 15 secondsSylvain Munaut1-1/+1
Also make sure to specify seconds in the 'seconds' field. Doing otherwise is an abuse that non longer works with the new timer infra. Signed-off-by: Sylvain Munaut <>
2011-10-18libbsc/nokia_site: Fix reset procedure and add option to skip it.Sylvain Munaut3-5/+33
do_reset was not initialized anywhere anymore, so the reset was never triggered. It's now fixed and we add an option to skip it in the config so that when in production, you can restart without config changes quickly. Signed-off-by: Sylvain Munaut <>
2011-10-17libbsc/nanobts: Fix NSVC OML init sequence for some rugby modelsSylvain Munaut1-1/+2
The NVC never goes to OFF LINE but only to DEPENDENCY (because of missing attributes). Signed-off-by: Sylvain Munaut <>
2011-10-17libbsc: Don't include ext_info in SI13 if not in EGPRS modeSylvain Munaut1-1/+1
Signed-off-by: Sylvain Munaut <>
2011-10-16GPRS GMM: When we receive a RA UPD REQ, we are NORMAL even after SUSPENDHarald Welte1-0/+3
There is no explicit BSSGP RESUME in case the MS sends a RA UPD REQ after being in SUSPEND previously.
2011-10-16GPRS LLC: fix compiler warningHarald Welte1-1/+1
2011-10-16GPRS GMM: Send LLGMM-RESET.req when talking to unknown MSHarald Welte1-0/+5
In case a MS (of which we have no MM context) sends us anything but a GMM ATTACH REQUEST, we need to send it a LLC XID RESET (by means of issuing LLGMM-RESET.req). Otherwise the phone will expect us to send a specific unacknowledged sequence number that we don't know. Thanks to Holger for pointing this bug out to me. It seems to commonly occur when a MS is doing network re-selection and (erroneously) sends a RA UPD REQ instead of an ATTACH REQ. The RA UPD REJ that we sent was never seen by the GMM entity in the MS, as the LLC entity discarded it due to sequence number mis-match.
2011-10-16LLC: Add minimal LLGMM-RESET.req implementationHarald Welte2-11/+87
Using LLGMM-RESET.req, the GMM can request the LLC of the MS to reset all its parameters, particularly the sequence numbers. We don't yet do XID RESET retransmissions, and we don't yet generate a LLGMM-RESET.conf primitive back to GMM.
2011-10-16misc: Linking fixes for Ubuntu 11.10 CompilerHolger Hans Peter Freyther7-19/+27
Ubuntu 11.10 has changed some linker/compiler flags. Some fixes for this can be seen here[1]. In general the to be linked libs need to be moved into the LDADD section of parameters. This is with the old BFD linker (not gold). This is likely to end in some ping-pong with other versions of the linker. [1] Errors: /usr/bin/ld.bfd.real: bsc_hack.o: undefined reference to symbol 'osmo_init_ignore_signals' /usr/bin/ld.bfd.real: note: 'osmo_init_ignore_signals' is defined in DSO /home/ich/install/openbsc/lib/ so try adding it to the linker command line /home/ich/install/openbsc/lib/ could not read symbols: Invalid operation ... ../../src/libbsc/libbsc.a(rest_octets.o):/home/ich/source/gsm/openbsc/openbsc/src/libbsc/rest_octets.c:381: more undefined references to `bitvec_set_bit' follow ../../src/libbsc/libbsc.a(rest_octets.o): In function `rest_octets_si13': /home/ich/source/gsm/openbsc/openbsc/src/libbsc/rest_octets.c:382: undefined reference to `bitvec_set_uint' /home/ich/source/gsm/openbsc/openbsc/src/libbsc/rest_octets.c:383: undefined reference to `bitvec_set_uint' /home/ich/source/gsm/openbsc/openbsc/src/libbsc/rest_octets.c:385: undefined reference to `bitvec_set_bit' /home/ich/source/gsm/openbsc/openbsc/src/libbsc/rest_octets.c:402: undefined reference to `bitvec_set_bit' /home/ich/source/gsm/openbsc/openbsc/src/libbsc/rest_octets.c:403: undefined reference to `bitvec_set_uint'
2011-10-14gprs: Fix various compiler warningsHolger Hans Peter Freyther2-2/+4
2011-10-14gprs: Fix compiler warnings in the codeHolger Hans Peter Freyther2-2/+4
2011-10-14gprs_gmm: Fix various compiler warningsHolger Hans Peter Freyther1-4/+7
gprs_gmm.c:240:2: warning: passing argument 4 of ‘gprs_llc_tx_ui’ discards qualifiers from pointer target type ../../include/openbsc/gprs_llc.h:151:5: note: expected ‘void *’ but argument is of type ‘const struct sgsn_mm_ctx *’ gprs_gmm.c:349:11: warning: unused variable ‘ptsig’ gprs_gmm.c:601:5: warning: too many arguments for format gprs_gmm.c:987:25: warning: initialization discards qualifiers from pointer target type gprs_gmm.c:1010:6: warning: ‘rc’ may be used uninitialized in this function
2011-10-14gprs: This comes from libosmocore, remove it hereHolger Hans Peter Freyther1-2/+0
2011-10-13osmo-sgsn: Install the osmo-sgsn configuration for debianHolger Hans Peter Freyther1-0/+1
2011-10-13sgsn: Add a configuration that is accepted by osmo-sgsnHolger Hans Peter Freyther1-0/+26
Provide an exmaple that is accepted by osmo-sgsn.
2011-10-12libctrl: only free() msgb if it was alloc()edAlexander Huemer1-1/+1
Before this patch a SIGABRT was caused when doing e.g.: $ ncat 4249 ^C
2011-10-12bsc: Put the full stop before the \n in the log messageHolger Hans Peter Freyther1-1/+1
2011-10-12bsc: Add new SCCP connections to the tailHolger Hans Peter Freyther1-1/+1
2011-10-12bsc: Drop the BTS instead of exiting the applicationHolger Hans Peter Freyther1-7/+12
When the BTS reboots it might not want to accept our BTS Attr, do not leave the bsc_msc_ip/bsc_nitb but simply drop the BTS connection. Manually cherry-picked from: 54e6c8b3400b376ed36fe84f28f7930d2d9ff24b
2011-10-12vty: Document more VTY parameters of a commandHolger Hans Peter Freyther1-33/+55
The below is used to identify commands that need proper documentation diff --git a/src/vty/command.c b/src/vty/command.c index ab1eaca..bcf72d0 100644 --- a/src/vty/command.c +++ b/src/vty/command.c @@ -426,6 +426,20 @@ void install_element(enum node_type ntype, struct cmd_element *cmd) cmd->strvec = cmd_make_descvec(cmd->string, cmd->doc); cmd->cmdsize = cmd_cmdsize(cmd->strvec); + + printf("NODE: %d\n", ntype); + + int j; + for (j = 0; j < vector_count(cmd->strvec); ++j) { + vector descvec = vector_slot(cmd->strvec, j); + int i; + for (i = 0; i < vector_active(descvec); i++) { + struct desc *desc = vector_slot(descvec, i); + if (desc == NULL) + continue; + printf(" %s %s\n", desc->cmd, desc->str); + } + } }