summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-04-30libmgcp: Parse CI as hex string in verify_ci()daniel/wipDaniel Willmann1-1/+1
In verify_ci CI needs to be parsed as hex instead of dec number as well. Fixes: OS#3951 Change-Id: I687b467756fa30cbc454e3583c86159d9abcc7d9
2019-04-23osmo-bsc_nat: Parse MGCP Connection ID as hexDaniel Willmann4-8/+11
Our ttcn3-bscnat-tests would randomly fail. After the CRCX ACK returns from the MSC the bsc-nat reports it could not find a CI it it and deletes the connection on the BSC-side. This happens because the field is parsed as a decimal value instead of hexadecimal. So a value of 00FED122 is parsed as '0' which is a reserved value in our program. This fix parses the field as hexadecimal value and also logs an error if the value happens to be 0. make check will now test if a hexadecimal CI is parsed correctly. Fixes: OS#3951 Change-Id: I49b8b61644bf706162102dce268cae2265536fc5
2019-04-21Fixed MNCC_RTP_CREATE after MNCC_DISC_IND.Rafael Diniz1-0/+3
Change-Id: I3690acebf882d3a8abbeabe0e3aefdfcd066a052
2019-03-29Write configuration correctly from vty (alert notifications)Keith1-2/+2
The default is [yes] alert-notifications, therefore write "no alert-notifications" in the case that this has been set, in order to preserve configuration after write is called from vty. Change-Id: I4b0363fa34dd9ac0a221844974e4ebf7465b56f4
2019-03-28vty_test_runner: Handle MGCP message recv len dynamicallyPau Espin Pedrol1-1/+12
Change-Id: I536d78a2a1962240e5e369cda9927d8c9955ab86
2019-03-28Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id onesPau Espin Pedrol4-12/+10
ipa_ccm_idtag_parse_off is broken, and can only be used with len_offset=1 on ID Request messages, otherwise won't work correctly. Modify ipa_ccm_idtag_parse to at least parse those correctly, and document the limitations. Those two functions are already deprecated and only used in openbsc by 3 callers: * ipa_ccm_idtag_parse in ussd_read_cb(): Broken, that function can only work for Requests and it's used to parse a Response. * ipa_ccm_idtag_parse_off in forward_sccp_to_msc (NAT): Broken, it can only be used to parse Requests and it's used to parse a Response. Furthermore, len_offset=2 is passed which makes no sense and most probably it fails always, or can even make the program crash. * ipa_ccm_idtag_parse_off in (answer_challenge): This one is fine and could actually be replaced with ipa_ccm_id_get_parse after libosmocore commit (see below) is merged. See libosmocore I6efc852dfc041192f554e41a58290a0f63298021 for more information. As a consequence of the fixes, osmo-bsc-nat now parses messages sent from VTY test correctly and thus it goes into processing them instead of silently dropping them. As a result, some VTY tests fail because they are sending incorrect format (missing NULL char in unit id strings) and osmo-bsc-nat closses its connection (due to bad auth). Change-Id: I3b995f8ef0b48c0a5b3375e42926641934359cd2
2019-03-26Drop Iu*S support and related dependenciesMax8-935/+1
There's optional libiu for Iu*S support but it's just a leftover from pre repo-split times: * it's not used by any code * it's not checked by gerrit verification in osmo-ci * it's disabled by default * it's not supported in .deb packages Instead of dragging old code in unknown stage of bit-rotting, let's just drop it completely. Change-Id: Id5678a74504b4456aba0438ccc34731770801128
2019-03-26Drop openggsn from build dependenciesMax1-2/+0
We don't have SGSN-related code here anymore so we don't need libgtp from openggsn any longer. Change-Id: I6725d39449a3d498adcd83fb8c3fe892367df0e8
2019-03-22talloc_ctx_init: Use public API osmo_signal_talloc_ctx_initPau Espin Pedrol1-2/+2
There's already a public API to allocate libosmocore's signal ctx, so let's use it instead of accessing the global variable. This will allow to eventually Make the global variable in libosmocore static and private. Change-Id: I8dab0ef810adba17fdd242e3a127908dd09b2b42
2019-03-20osmo-bsc-mgcp.service: Fix parsing of cmdline option sPau Espin Pedrol1-1/+1
From journald output: /usr/bin/osmo-bsc_mgcp: invalid option -- 's' Change-Id: I995d2f5909640fc007aa39dd6c6b54ff97ee45f7
2019-02-28Don't deliver alert notifications to an ESME thatKeith3-5/+10
is not yet bound. We create a new ESME in smsc->esme_list on establishment of a TCP connection, yet we do not know the system id or anything else, until the ESME identifies and authenticates. So do not send alert notifications until we know the bind status (and system_id) Change-Id: I0e5d55d3fb6ac46d253902df2fe304e1b0fc8bbf
2019-01-30Bump version: 1.1.0.120-9981 → 1.2.01.2.0Pau Espin Pedrol2-9/+154
Change-Id: I33e1c83a0000789f65acc0b7584d1629a50b384c
2019-01-24Remove osmocom-ipaccess-utils-dbg packageMax1-8/+0
The rest was dropped in I9c04f9b469e60802461a2a6e421d3ba27e6dafa1. Change-Id: If56c288121bd26fead9a921c1f04f9958468e1b6
2019-01-24Remove openbsc-dev packageMax5-28/+0
There're no external utilities which rely on it anymore so we can simplify our packaging by removing it. Change-Id: I9a96c217999416099aa7ce690845f56fc132274c
2019-01-24Remove meas_* utilsMax7-1199/+0
The counterparts in OsmoBSC repo are actively maintained and (partially) packaged for .deb - let's drop old versions to minimize user confusion. Change-Id: Ia0cedaad4b717c8c5198842e2acd610f8e03f957
2019-01-22fix build: apply msgb_wrap_with_TL() renameMax1-7/+7
After libosmocore commit If1e851ac605c8d2fde3da565b0bd674ea6350c2e b27e6feb699712345373e87a48187dc622e4fa92 the openbsc master build is broken. Apply the msgb_wrap_with_TL() rename to msgb_push_tl() to unbreak the build. Also related is commit e8cd09dd6f3378a8137afb581dcd7ed554daa24c in this repository, which removed the locally defined msgb_wrap_with_TL() definition. The libosmocore mistake should have become obvious then and there... Change-Id: I6fece7bbbea84962daff885e54f0bc0108c8d0a5
2019-01-17Cosmetic: Fix spelling in smpp vtyKeith1-2/+2
Change-Id: If2180828e2acd28d96754c593c317c2868644c4b
2019-01-17Make alert notifications vty configurable per ESMEKeith4-2/+34
OSMO-MSC backport Adds (no) alert-notifications as a per-esme vty command, in order to allow some ESMEs to be excluded from alerts. The default is still to send alert notifications to all esme, so no changes are required to the config file to maintain identical operation after this patch. Change-Id: I2b52f2778b24eebc82b2e5e2fb3c2250b1f9e5b0
2019-01-12Don't send SMS STATUS REPORT locally if the ESME accepted it.Keith1-1/+1
Backport of https://gerrit.osmocom.org/11792/ When using smpp-first, after the ESME accepts our STATUS REPORT, we were sending it locally into gsm340_rx_sms_submit() anyway. In the case of the ESME mirroring the report back to us, this would result in two copies of the status report in the SMS database, which were also both then delivered to the MS. Some MS then display the REPORT to the user as if it were a normal SMS. With this patch, we check if it is the sms_report that has had receiver set in sms_route_mt_sms() and not the original SMS we are reporting on, which of course already has receiver set. Change-Id: I2136489bd21c4755463278a4048a446e5bc4a9d2
2018-12-12contrib/jenkins.sh: build and publish manualsOliver Smith1-0/+29
Add new environment variables WITH_MANUALS and PUBLISH to control if the manuals should be built and uploaded. Describe all environment vars on top of the file. Related: OS#3385 Change-Id: I89be11d346d50169282c991235ffc47dacc30b11
2018-12-06contrib: fix makedistcheck with disabled systemdOliver Smith1-1/+6
EXTRA_DIST files need to be distributed, no matter if the systemd option is configured or not. Change-Id: I8dbb17571df5d6cea040498af2fe57f087bdeb24
2018-12-06Remove ipaccess utilsMax12-2935/+0
There's increasing gap in functionality between ipaccess utils from this repo and from osmo-bsc due to ongoing development in new repository. To avoid potential user confusion let's drop them similar to the way SGSN was removed earlier. Change-Id: I9c04f9b469e60802461a2a6e421d3ba27e6dafa1
2018-12-04Fix DISTCHECK_CONFIGURE_FLAGS overrideOliver Smith1-1/+1
Set AM_DISTCHECK_CONFIGURE_FLAGS in Makefile.am instead of DISTCHECK_CONFIGURE_FLAGS. This is the recommended way from the automake manual, as otherwise the flag can't be changed by the user anymore. Related: OS#3718 Change-Id: I88cc2058bc4ff07d092b060d4cc4e28c3203c625
2018-11-30manuals: Osmo{NAT,MGCP} -> OsmoBSC{NAT,MGCP}Oliver Smith8-4/+4
Rename the manuals to their proper names. Change-Id: I8c020361c141c758bfb32562dbd7f34f4fd81c39
2018-11-29OsmoMGCP and OsmoNAT manuals moved from osmo-gsm-manuals.gitOliver Smith8-0/+3606
Add both manuals to manuals/OsmoMGCP and manuals/OsmoNAT. Build them just like the existing OsmoNITB manual: $ cd manuals/OsmoMGCP $ make The commit history only consisted of the initial commit and was not imported. Related: OS#3385 Change-Id: Ibace91bc518079765e12529596a1763b6c5a04b5
2018-11-29manuals/OsmoNITB: integrate into this repositoryOliver Smith15-6/+36
Move from doc/manuals to manuals/OsmoNITB as we have two more manuals (OsmoMGCP and OsmoNAT) that need to be moved to manuals/. Make the manuals build without a toplevel configure.ac file from autotools: $ cd manuals/OsmoNITB $ make openbsc/configure.ac is not used to integrate the manuals, as it would be extra effort to integrate all three of the manuals there. This is not worth it for the legacy codebase. Related: OS#3385 Change-Id: I0036ad8dbecd23695305ac491c7ee87caa44c7f9
2018-11-28build manuals moved here from osmo-gsm-manuals.gitOliver Smith4-31/+36
Moved to doc/manuals/, with full commit history, in preceding merge commit. Now incorporate in the build system. Build with: $ autoreconf -fi $ ./configure --enable-manuals $ make Shared files from osmo-gsm-manuals.git are found automatically if - the repository is checked out in ../osmo-gsm-manuals; or - if it osmo-gsm-manuals was installed with "make install"; or - OSMO_GSM_MANUALS_DIR is set. Related: OS#3385 Change-Id: I4466d820cb3a5609a4a8534b1581684f891a04cd
2018-11-28Merge history from osmo-gsm-manuals.gitNeels Hofmeyr13-0/+6034
Change-Id: I298828d47ce86c13301f5ab245934fbcf8d8d2d3
2018-11-28vty/bsc_vty_additions.xml: copy from osmo-bscOliver Smith1-1/+10
Replace the symlink with a full copy, as the manuals are in the project repositories now. Related: OS#3385
2018-11-28author info: add "former" to Holger's job titleNeels Hofmeyr1-1/+1
It doesn't seem to have an effect on the generated PDFs though. Change-Id: I0556a3f8dafc051f20a3854fc9006edf4ec1a0d3
2018-11-28vty-ref: Update URI of docbook 5.0 schemaHarald Welte1-2/+2
... to match the /etc/xml/catalog file on debian (no "www" in hostname) Change-Id: Id9f3579c7f2bc3af13fe30b5268f249b6f59ed0d
2018-11-28refactor Makefile build rules, don't use the FORCENeels Hofmeyr2-40/+7
The initial goal was to make sure we don't have overall FORCE rules causing unnecessary rebuilds -- annoying while writing documentation. As I looked through possible dependencies, I finally understood what's going on here. Remove code dup and nicely sort which belongs where in build/Makefile.*.inc. In each, describe in a top comment how to use it, and also unify how they are used: - Rename Makefile.inc to Makefile.docbook.inc and refactor - Add Makefile.vty-reference.inc - Add Makefile.common.inc Make sure that we accurately pick up all dependencies. Drop use of the macro called 'command', that silenced the actual command lines invoked and replaced them with short strings: it obscures what is actually going on and makes the Makefiles hard to read and understand. Each manual's makefile is greatly reduced to few definitions and a Makefile include, e.g. one for asciidoc, one for VTY reference. Move common/bsc_vty_additions.xml to OsmoBSC/vty/libbsc_vty_additions.xml, link from OsmoNITB. It applies only to OsmoBSC and OsmoNITB. Add a script that combines a VTY reference file with *all* additions files found in a manual's vty/ dir. Call this from Makefile.vty-reference.inc. Change-Id: I9758e04162a480e28c7dc83475b514cf7fd25ec0
2018-11-28OsmoNITB: update vty referenceNeels Hofmeyr2-118/+761
Change node IDs to use the names derived from the node prompt, in the process fix the node references to not place the vty_additions in the wrong places. Related: I8fa555570268b231c5e01727c661da92fad265de (libosmocore) Change-Id: I48edb65be94be56c4b57293d8edc1b30271acc12
2018-11-28move smpp.adoc to common chapters, generalizeNeels Hofmeyr2-145/+1
OsmoMSC will need the same SMPP chapter as OsmoNITB. In smpp.adoc, replace program name with parameter, add parameter to OsmoNITB's main adoc and move smpp.adoc to common/chapters. Change-Id: I15febdea6569316dad3eed5f9dc7158adb5b078c
2018-11-28tweak common/mncc.adoc: use variable for program nameNeels Hofmeyr1-0/+1
Change-Id: I993a3c3bf617b9823f49898364b5f728a4549330
2018-11-28move mncc.adoc to common chaptersNeels Hofmeyr2-207/+1
Upcoming OsmoMSC will reference the same, hence MNCC becomes a common chapter. Move the file and adjust various wording to include OsmoMSC. Change-Id: I404758ff7f1372e841ffe33c75455f513fff3caf
2018-11-28Allow easily disabling GFDL referencesPau Espin Pedrol1-0/+2
All parts referencing GFDL can be easily disabled by removing the 'gfdl-enabled' attribute from the document. Change-Id: I2489726ad2e90301bceadfada926e31ae0f85986
2018-11-28SMPP: Document Osmocom extensionsHarald Welte1-2/+51
Change-Id: I4cedd07a33633bdd2350d2bda0a22cc0c631c0a9
2018-11-28smpp.adoc: describe VTY cmd 'local-tcp-ip' instead of 'local-tcp-port'Pau Espin Pedrol1-4/+5
Change-Id: I594b89094413758146bb25f5262902e263f8f3d1
2018-11-28osmo-nitb: Update VTY command referencePhilipp Maier2-393/+1045
Change-Id: Ia4c2d71eeca853ef277e802e9e8e200eb3414bca
2018-11-28Add chapter on Cell Broadcast Support in Osmocom (to BSC+NITB manual)Harald Welte1-0/+2
Change-Id: I2c621def499dc0564d31eb9440e22e79948a5466
2018-11-28Describe how to run multiple instances of osmo-nitb and osmo-btsPhilipp1-1/+45
Change-Id: I69adeef85adda6f08b31b7d176f51e16968c1435
2018-11-28fix 'make clean': shell glob, ignore failureNeels Hofmeyr1-2/+4
Unfortunately a glob like osmo-x__*.{svg,png} doesn't work, so have the suffixes in separate globs. Add dashes to indicate that failure should be ignored. Change-Id: I6bc4d9ea72b43a573acbc860c23397f748de2c7b
2018-11-28OsmoNITB: include abis.adoc from common/chapters/Neels Hofmeyr1-1/+1
Change-Id: If3d92fe19d402d77b0db0eb9d00efef0a8d02122
2018-11-28OsmoBSC+NITB/running: fix title levels, one too deepNeels Hofmeyr1-2/+2
Change-Id: If81e44c9a0774e5de39cc536989cef5cb214a224
2018-11-28add 'make check' targetNeels Hofmeyr1-1/+1
Generate *.check files from asciidoc output and grep for WARNINGs. Add *.check files to gitignore and to 'make clean'. Change-Id: Ibccc83a3415930a528f2e8e4e4dda3b81c6d0b64
2018-11-28make clean: also remove generated image filesNeels Hofmeyr1-0/+1
Change-Id: I80798e79b4ccee64f26f58f9754de02b2958e33e
2018-11-28Typo in Chapter 14.2Ivaylo Kostov1-1/+1
2018-11-28Add OsmoNITB control interface descriptionMax2-0/+59
2018-11-28fix various typos across all manualsJonathan Brielmaier4-5/+5