summaryrefslogtreecommitdiffstats
path: root/openbsc
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2019-08-05 16:39:52 +0200
committerPau Espin Pedrol <pespin@sysmocom.de>2019-08-05 16:39:52 +0200
commit9383e302bd92541f3f71dd00fdfa57afe8d5f195 (patch)
tree6bcebc2fa558ed60984ba97f42616ea11cf3122d /openbsc
parentfec1db95f5d30b359753ac352caa8fb69fa16a95 (diff)
Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds
Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However, definition in C file doesn't contain "(void)", which means number of parameters is undefined and thus compiler doesn't complain. Let's remove parameters from all callers before enforcing "(void)" on it. API osmo_stats_vty_add_cmds never had a param list but has seem problem (no "void"), so some users decided to pass a parameter to it. Change-Id: I7d9d477b983b0d62f01237d90acaa7ce455c3c3d Related: OS#4138
Diffstat (limited to 'openbsc')
-rw-r--r--openbsc/src/libbsc/bsc_vty.c2
-rw-r--r--openbsc/src/osmo-bsc_mgcp/mgcp_main.c4
-rw-r--r--openbsc/src/osmo-bsc_nat/bsc_nat.c4
3 files changed, 5 insertions, 5 deletions
diff --git a/openbsc/src/libbsc/bsc_vty.c b/openbsc/src/libbsc/bsc_vty.c
index c71ea4a3e..55a716b67 100644
--- a/openbsc/src/libbsc/bsc_vty.c
+++ b/openbsc/src/libbsc/bsc_vty.c
@@ -4335,7 +4335,7 @@ int bsc_vty_init(struct gsm_network *network)
install_element_ve(&show_paging_cmd);
install_element_ve(&show_paging_group_cmd);
- logging_vty_add_cmds(NULL);
+ logging_vty_add_cmds();
osmo_stats_vty_add_cmds();
install_element(GSMNET_NODE, &cfg_net_neci_cmd);
diff --git a/openbsc/src/osmo-bsc_mgcp/mgcp_main.c b/openbsc/src/osmo-bsc_mgcp/mgcp_main.c
index 419f852d7..220efa3e8 100644
--- a/openbsc/src/osmo-bsc_mgcp/mgcp_main.c
+++ b/openbsc/src/osmo-bsc_mgcp/mgcp_main.c
@@ -222,8 +222,8 @@ int main(int argc, char **argv)
vty_info.copyright = openbsc_copyright;
vty_init(&vty_info);
- logging_vty_add_cmds(NULL);
- osmo_stats_vty_add_cmds(&log_info);
+ logging_vty_add_cmds();
+ osmo_stats_vty_add_cmds();
mgcp_vty_init();
handle_options(argc, argv);
diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c b/openbsc/src/osmo-bsc_nat/bsc_nat.c
index 2e2eac04d..9bb33adcf 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c
@@ -1628,8 +1628,8 @@ int main(int argc, char **argv)
vty_info.copyright = openbsc_copyright;
vty_init(&vty_info);
- logging_vty_add_cmds(NULL);
- osmo_stats_vty_add_cmds(&log_info);
+ logging_vty_add_cmds();
+ osmo_stats_vty_add_cmds();
bsc_nat_vty_init(nat);
ctrl_vty_init(tall_bsc_ctx);