aboutsummaryrefslogtreecommitdiffstats
path: root/openbsc
diff options
context:
space:
mode:
authorNeels Hofmeyr <nhofmeyr@sysmocom.de>2016-12-08 01:01:06 +0100
committerNeels Hofmeyr <nhofmeyr@sysmocom.de>2016-12-08 01:38:58 +0100
commit47a63ad0320388a03d208ac46cbc9a200b1c9616 (patch)
tree858e962be4d85e88c62edd2f502a512396320710 /openbsc
parent226e663298b95cdd22b11483c24a949a3e7f5f45 (diff)
vlr: add vlr_subscriber to gsm_subscriber and comment
Diffstat (limited to 'openbsc')
-rw-r--r--openbsc/include/openbsc/gsm_subscriber.h23
1 files changed, 23 insertions, 0 deletions
diff --git a/openbsc/include/openbsc/gsm_subscriber.h b/openbsc/include/openbsc/gsm_subscriber.h
index 314d61923..f683cd54b 100644
--- a/openbsc/include/openbsc/gsm_subscriber.h
+++ b/openbsc/include/openbsc/gsm_subscriber.h
@@ -45,6 +45,29 @@ struct gsm_equipment {
};
struct gsm_subscriber {
+ /* VLR work in progress: the long term aim is to completely eliminate
+ * gsm_subscriber; in libmsc, to replace it with vlr_subscriber, in
+ * libbsc in the osmo-bsc case to not have any gsm_subscriber at all,
+ * and in the osmo-nitb case to have a pointer to the vlr_subscriber
+ * for logging and debugging that is left NULL in osmo-bsc. But to be
+ * able to move there in small increments, I'm first keeping
+ * gsm_subscriber and merely point at the "future real" vlr_subscriber
+ * from here. To completely replace gsm_subscriber, these things need
+ * to be resolved:
+ * - provide id in vlr_subscriber for libmsc's VTY 'subscriber id N';
+ * - refactor libmsc paging to remember the paging requests with cb in
+ * vlr_subscriber or an entirely separate list -- see 'requests'
+ * below, subscr_request_channel() and paging.c;
+ * - in libbsc paging, don't reference the subscriber in a paging
+ * request, simply pass a MI (TMSI or IMSI) to the paging API;
+ * - in libbsc, store IMSI, TMSI and LAC in the subscriber_conn (?);
+ * - use vlr_sub_name() instead of subscr_name() in various logging;
+ * - in libbsc, log the subscriber info only when available;
+ * - move classmark info to subscriber_conn ('equipment' below);
+ * - in the SGSN, <TODO: insert convincing plan here>
+ */
+ struct vlr_subscriber *vsub;
+
struct gsm_subscriber_group *group;
long long unsigned int id;
char imsi[GSM23003_IMSI_MAX_DIGITS+1];