path: root/openbsc/src
diff options
authorHarald Welte <>2016-04-27 18:21:16 +0200
committerHarald Welte <>2016-04-29 13:10:37 +0200
commit5d547a4358edbd18744d1996d6ecb40328f09061 (patch)
tree866489ca9f7ec7be7ee8016e41680d61a819bb29 /openbsc/src
parentd8aa412c46638abea05488ebb2e9d70ca7fd628a (diff)
osmo_oap_decode(): Use common argument ordering
In general, if a function generates output data like a msgb (or in this case filling an osmo_oap_message structure), the output argument precedes the source. This is what we use all over libosmo*, and it is modelled after memcpy(), where dst is the first argument, before src. Let's align osmo_oap_decode(). Intestingly, osmo_oap_encode was already correct, so the encode/decode functions used different conventions before.
Diffstat (limited to 'openbsc/src')
2 files changed, 3 insertions, 3 deletions
diff --git a/openbsc/src/gprs/oap.c b/openbsc/src/gprs/oap.c
index a9fee566b..c7c97774d 100644
--- a/openbsc/src/gprs/oap.c
+++ b/openbsc/src/gprs/oap.c
@@ -214,7 +214,7 @@ int oap_handle(struct oap_state *state, const struct msgb *msg_rx, struct msgb *
- rc = osmo_oap_decode(data, data_len, &oap_msg);
+ rc = osmo_oap_decode(&oap_msg, data, data_len);
if (rc < 0) {
"Decoding OAP message failed with error '%s' (%d)\n",
diff --git a/openbsc/src/gprs/oap_messages.c b/openbsc/src/gprs/oap_messages.c
index 53ea9ac84..d81723fd6 100644
--- a/openbsc/src/gprs/oap_messages.c
+++ b/openbsc/src/gprs/oap_messages.c
@@ -31,8 +31,8 @@
#include <stdint.h>
-int osmo_oap_decode(const uint8_t *const_data, size_t data_len,
- struct osmo_oap_message *oap_msg)
+int osmo_oap_decode(struct osmo_oap_message *oap_msg,
+ const uint8_t *const_data, size_t data_len)
int rc;
uint8_t tag;