subscr: Remember if we need to call subscr_put_channel at the end.

Remember if this channel got opened due a paging response and in
that case when we close it down we will call subscr_put_channel
that will try to page the subscriber again. This highlights the
lack of a good subscriber management in the MSC code.

1 files changed, 8 insertions, 0 deletions

diff --git a/openbsc/src/osmo_msc.c b/openbsc/src/osmo_msc.c
index beb90e5b1..8c86dcc8e 100644
--- a/openbsc/src/osmo_msc.c
+++ b/openbsc/src/osmo_msc.c
@@ -38,6 +38,10 @@ static void msc_sapi_n_reject(struct gsm_subscriber_connection *conn, int dlci)
 static int msc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause)
 {
 	gsm0408_clear_request(conn, cause);
+	if (conn->put_channel) {
+		conn->put_channel = 0;
+		subscr_put_channel(conn->subscr);
+	}
 	return 1;
 }
 
@@ -92,5 +96,9 @@ void msc_release_connection(struct gsm_subscriber_connection *conn)
 	/* no more connections, asking to release the channel */
 	conn->in_release = 1;
 	gsm0808_clear(conn);
+	if (conn->put_channel) {
+		conn->put_channel = 0;
+		subscr_put_channel(conn->subscr);
+	}
 	subscr_con_free(conn);
 }