path: root/openbsc/src/osmo-bsc
diff options
authorHolger Hans Peter Freyther <>2014-05-06 06:45:30 +0200
committerHolger Hans Peter Freyther <>2014-05-06 06:50:39 +0200
commitabddd6aa441b85d030f0f9c12ca326cf956063fb (patch)
treeaf9546ae7ca32a69c232da8c697ad74cf48b8fe4 /openbsc/src/osmo-bsc
parent3c9068f185dd76d1051e58f1423b4ae612d12ee3 (diff)
nat/bsc: Check proto before calling ipaccess_rcvmsg_base
The code in the BSC/NAT called ipaccess_rcvmsg_base without checking if the protocol is IPA. This lead the BSC to respond to SCCP messages with an "ID ACK". From a quick look neither the code of ipaccess_rcvmsg_base in OpenBSC nor the copy of libosmo-abis ever checked the protocol header. So this code has been wrong since initially being created in 2010.
Diffstat (limited to 'openbsc/src/osmo-bsc')
1 files changed, 1 insertions, 1 deletions
diff --git a/openbsc/src/osmo-bsc/osmo_bsc_msc.c b/openbsc/src/osmo-bsc/osmo_bsc_msc.c
index 04e9cf3a7..0acc29027 100644
--- a/openbsc/src/osmo-bsc/osmo_bsc_msc.c
+++ b/openbsc/src/osmo-bsc/osmo_bsc_msc.c
@@ -270,11 +270,11 @@ static int ipaccess_a_fd_cb(struct osmo_fd *bfd)
/* handle base message handling */
hh = (struct ipaccess_head *) msg->data;
- ipaccess_rcvmsg_base(msg, bfd);
/* initialize the networking. This includes sending a GSM08.08 message */
msg->cb[0] = (unsigned long) data;
if (hh->proto == IPAC_PROTO_IPACCESS) {
+ ipaccess_rcvmsg_base(msg, bfd);
if (msg->l2h[0] == IPAC_MSGT_ID_ACK)
else if (msg->l2h[0] == IPAC_MSGT_ID_GET) {