diff options
| author | Holger Hans Peter Freyther <holger@moiji-mobile.com> | 2013-07-14 08:50:57 +0200 |
|---|---|---|
| committer | Holger Hans Peter Freyther <holger@moiji-mobile.com> | 2013-07-14 09:04:50 +0200 |
| commit | ae9d8d3131effe1243ed38f729440b8c0adcc808 (patch) | |
| tree | 7aff2b111f3f23d1272142d7b9dcb094eeaf1008 /openbsc/src/libmsc/smpp_vty.c | |
| parent | c9251fa8c9e3bc6ea2ea9182e0f1b13b16f065ca (diff) | |
smpp: Checking an array for NULL will always be false
The if (submit->short_message) and if (smsc->system_id) will
always be true.
Fixes: Coverity CID 1042371, CID 1042372
Diffstat (limited to 'openbsc/src/libmsc/smpp_vty.c')
| -rw-r--r-- | openbsc/src/libmsc/smpp_vty.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/openbsc/src/libmsc/smpp_vty.c b/openbsc/src/libmsc/smpp_vty.c index a2270e62a..c412bb320 100644 --- a/openbsc/src/libmsc/smpp_vty.c +++ b/openbsc/src/libmsc/smpp_vty.c @@ -119,7 +119,7 @@ static int config_write_smpp(struct vty *vty) vty_out(vty, "smpp%s", VTY_NEWLINE); vty_out(vty, " local-tcp-port %u%s", smsc->listen_port, VTY_NEWLINE); - if (smsc->system_id && strlen(smsc->system_id) > 0) + if (strlen(smsc->system_id) > 0) vty_out(vty, " system-id %s%s", smsc->system_id, VTY_NEWLINE); vty_out(vty, " policy %s%s", smsc->accept_all ? "accept-all" : "closed", VTY_NEWLINE); |