diff options
| author | Holger Hans Peter Freyther <holger@moiji-mobile.com> | 2013-07-14 08:50:57 +0200 |
|---|---|---|
| committer | Holger Hans Peter Freyther <holger@moiji-mobile.com> | 2013-07-14 09:04:50 +0200 |
| commit | ae9d8d3131effe1243ed38f729440b8c0adcc808 (patch) | |
| tree | 7aff2b111f3f23d1272142d7b9dcb094eeaf1008 /openbsc/src/libmsc/smpp_openbsc.c | |
| parent | c9251fa8c9e3bc6ea2ea9182e0f1b13b16f065ca (diff) | |
smpp: Checking an array for NULL will always be false
The if (submit->short_message) and if (smsc->system_id) will
always be true.
Fixes: Coverity CID 1042371, CID 1042372
Diffstat (limited to 'openbsc/src/libmsc/smpp_openbsc.c')
| -rw-r--r-- | openbsc/src/libmsc/smpp_openbsc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/openbsc/src/libmsc/smpp_openbsc.c b/openbsc/src/libmsc/smpp_openbsc.c index 1cbc4b076..e41d37776 100644 --- a/openbsc/src/libmsc/smpp_openbsc.c +++ b/openbsc/src/libmsc/smpp_openbsc.c @@ -113,7 +113,7 @@ static int submit_to_sms(struct gsm_sms **psms, struct gsm_network *net, } sms_msg = t->value.octet; sms_msg_len = t->length; - } else if (submit->short_message && submit->sm_length) { + } else if (submit->sm_length) { sms_msg = submit->short_message; sms_msg_len = submit->sm_length; } else { |