aboutsummaryrefslogtreecommitdiffstats
path: root/openbsc/src/libbsc/rest_octets.c
diff options
context:
space:
mode:
authorHarald Welte <laforge@gnumonks.org>2017-09-30 09:22:30 +0800
committerHarald Welte <laforge@gnumonks.org>2017-10-01 11:11:30 +0800
commitdb1f75c3e305b87577d219365811fa5e5037a80d (patch)
treee21e2ef1eb4dcc376a9c545e62280a3863f62657 /openbsc/src/libbsc/rest_octets.c
parent725bcb71f07e572672bdeb878bb1fbd94bb44eba (diff)
Make sure BA-IND in all SI2xxx is '0' and in all SI5xxx is '1'
In masurement reports sent by the MS, this can then be used to correlate if a given measurement report was in response to a BCCH/neighbor list received on BCCH (SI2xxx) or on dowlink SACCH (SI5xxx). Closes: OS#2525 Change-Id: I1cd0dc51026dcd0e508e63eea4e333e6b184787a
Diffstat (limited to 'openbsc/src/libbsc/rest_octets.c')
-rw-r--r--openbsc/src/libbsc/rest_octets.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/openbsc/src/libbsc/rest_octets.c b/openbsc/src/libbsc/rest_octets.c
index 78e7413a8..7b77ce217 100644
--- a/openbsc/src/libbsc/rest_octets.c
+++ b/openbsc/src/libbsc/rest_octets.c
@@ -361,8 +361,12 @@ int rest_octets_si2quater(uint8_t *data, struct gsm_bts *bts)
bv.data_len = 20;
bitvec_zero(&bv);
- /* BA_IND */
- bitvec_set_bit(&bv, 1);
+ /* BA_IND: Set to '0' as that's what we use for SI2xxx type,
+ * whereas '1' is used for SI5xxx type messages. The point here
+ * is to be able to correlate whether a given MS measurement
+ * report was using the neighbor cells advertised in SI2 or in
+ * SI5, as those two could very well be different */
+ bitvec_set_bit(&bv, 0);
/* 3G_BA_IND */
bitvec_set_bit(&bv, 1);
/* MP_CHANGE_MARK */