diff options
| author | Harald Welte <laforge@gnumonks.org> | 2012-07-14 12:15:19 +0200 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2012-07-14 12:18:28 +0200 |
| commit | fdf453c0a97841cf238191eef63382b650ffe07f (patch) | |
| tree | 09249640b985f0a5a52857fa38f99ca2755c73e4 /openbsc/src/gprs/sgsn_libgtp.c | |
| parent | 7b022eed2d211eada63d2fe1f89b02455f501b9b (diff) | |
SGSN: Code to help debug / fix sgsn crash in cb_data_ind()
A crash was obsserved in cb_data_ind() when mm is dereferenced.
This patch adds some safeguards that try to prevent the library handle
back-pointer to the pdp_ctx to be NULL, and print a stack backtrace in
case we are free() ing the sgsn-side pdp_ctx while there's still a
library handle attached.
Diffstat (limited to 'openbsc/src/gprs/sgsn_libgtp.c')
| -rw-r--r-- | openbsc/src/gprs/sgsn_libgtp.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/openbsc/src/gprs/sgsn_libgtp.c b/openbsc/src/gprs/sgsn_libgtp.c index a19af366e..7c17f9d41 100644 --- a/openbsc/src/gprs/sgsn_libgtp.c +++ b/openbsc/src/gprs/sgsn_libgtp.c @@ -317,6 +317,10 @@ static int delete_pdp_conf(struct pdp_t *pdp, void *cbp, int cause) /* Confirm deactivation of PDP context to MS */ rc = gsm48_tx_gsm_deact_pdp_acc(pctx); + /* unlink the now non-existing library handle from the pdp + * context */ + pctx->lib = NULL; + sgsn_pdp_ctx_free(pctx); return rc; @@ -422,10 +426,16 @@ static int cb_data_ind(struct pdp_t *lib, void *packet, unsigned int len) pdp = lib->priv; if (!pdp) { - DEBUGP(DGPRS, "GTP DATA IND from GGSN for unknown PDP\n"); + LOGP(DGPRS, LOGL_NOTICE, + "GTP DATA IND from GGSN for unknown PDP\n"); return -EIO; } mm = pdp->mm; + if (!mm) { + LOGP(DGPRS, LOGL_ERROR, + "PDP context (imsi=%s) without MM context!\n", mm->imsi); + return -EIO; + } msg = msgb_alloc_headroom(len+256, 128, "GTP->SNDCP"); ud = msgb_put(msg, len); |