diff options
| author | Jacob Erlbeck <jerlbeck@sysmocom.de> | 2015-01-15 17:08:30 +0100 |
|---|---|---|
| committer | Jacob Erlbeck <jerlbeck@sysmocom.de> | 2015-01-19 08:30:01 +0100 |
| commit | 1635150f2ccfb3cba636b42ac8aa1c916e0ae8ec (patch) | |
| tree | 8a36aa017edd261de9a31631eef62a878faf7c7e /openbsc/include | |
| parent | a688976f10bfb0c14954a066aa133f28bce3a541 (diff) | |
gprs: Add replies for all GSUP requests
Currently, an incoming GSUP request message isn't answered at all if
it is not handled due to an error or missing implementation.
This patch adds GSUP error replies for these requests (and only for
requests). It also adds tests for these cases.
Note that several of these tests check for
GMM_CAUSE_MSGT_NOTEXIST_NOTIMPL, which will have to be changed, when
the features are implemented.
Sponsored-by: On-Waves ehf
Diffstat (limited to 'openbsc/include')
| -rw-r--r-- | openbsc/include/openbsc/gprs_gsup_messages.h | 4 | ||||
| -rw-r--r-- | openbsc/include/openbsc/gprs_sgsn.h | 3 |
2 files changed, 6 insertions, 1 deletions
diff --git a/openbsc/include/openbsc/gprs_gsup_messages.h b/openbsc/include/openbsc/gprs_gsup_messages.h index b63f74baa..9857b979d 100644 --- a/openbsc/include/openbsc/gprs_gsup_messages.h +++ b/openbsc/include/openbsc/gprs_gsup_messages.h @@ -74,6 +74,10 @@ enum gprs_gsup_message_type { GPRS_GSUP_MSGT_LOCATION_CANCEL_RESULT = 0b00011110, }; +#define GPRS_GSUP_IS_MSGT_REQUEST(msgt) (((msgt) & 0b00000011) == 0b00) +#define GPRS_GSUP_IS_MSGT_ERROR(msgt) (((msgt) & 0b00000011) == 0b01) +#define GPRS_GSUP_TO_MSGT_ERROR(msgt) (((msgt) & 0b11111100) | 0b01) + enum gprs_gsup_cancel_type { GPRS_GSUP_CANCEL_TYPE_UPDATE = 1, /* on wire: 0 */ GPRS_GSUP_CANCEL_TYPE_WITHDRAW = 2, /* on wire: 1 */ diff --git a/openbsc/include/openbsc/gprs_sgsn.h b/openbsc/include/openbsc/gprs_sgsn.h index d6a9bdada..25810ab3a 100644 --- a/openbsc/include/openbsc/gprs_sgsn.h +++ b/openbsc/include/openbsc/gprs_sgsn.h @@ -289,7 +289,8 @@ struct sgsn_subscriber_data { }; #define LOGGSUBSCRP(level, subscr, fmt, args...) \ - LOGP(DGPRS, level, "SUBSCR(%s) " fmt, (subscr)->imsi, \ + LOGP(DGPRS, level, "SUBSCR(%s) " fmt, \ + (subscr) ? (subscr)->imsi : "---", \ ## args) struct sgsn_config; |