diff options
| author | Pau Espin Pedrol <pespin@sysmocom.de> | 2018-10-12 20:10:07 +0200 |
|---|---|---|
| committer | Pau Espin Pedrol <pespin@sysmocom.de> | 2018-10-12 20:52:40 +0200 |
| commit | 4a2cc9eb0a0f9424c16b26fcb757483a39d67482 (patch) | |
| tree | e228f6544fdf9066f3d5da4f9f9b4e8cfef28ae9 /openbsc/Makefile.am | |
| parent | 96bd7b075a59eb051079152241b127ca944b0781 (diff) | |
mgcp: osmux: Improve checks around activating and using enabled osmux
* Refactor code to have unified checks on all paths activating Osmux.
* Improve checkings at activation time and add logging.
* Code now enforces endp osmux status to be enabled before processing
the frame through endp->osmux.out. Before, a delayed or bad pkt could
arrive and be processed by an endp with osmux not enabled, using
endp->osmux.out that was not initialized and ended up crashing:
libosmo-netif/src/osmux.c:281:3: runtime error: member access within null pointer of type 'struct msgb'
This could also happen if a BSC started sending or we received (non legacy dummy) osmux
frames before we received the BSC CRCX ACK agreeing on osmux negotiation
and switching to ACTIVATING state.
Related: SYS#4350
Change-Id: I3536169c94e65f999aaa9c9e43cc7dab8551d30f
Diffstat (limited to 'openbsc/Makefile.am')
0 files changed, 0 insertions, 0 deletions