summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHolger Hans Peter Freyther <holger@moiji-mobile.com>2015-08-04 12:22:56 +0200
committerHolger Hans Peter Freyther <holger@moiji-mobile.com>2015-08-08 20:46:50 +0200
commit5425e5ea27e3d5b4ce43c1e2ae40252dd14ddfb0 (patch)
tree8cbd8e3c16c82416349feb5fb7365f230dca6250
parent815945550685249aa002ef55b9ef990faa10ee0e (diff)
subscr: Fix subscr refcount issue in case of message error
In case the SMPP payload didn't include the right fields we would leak the subscr reference count.
-rw-r--r--openbsc/src/libmsc/smpp_openbsc.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/openbsc/src/libmsc/smpp_openbsc.c b/openbsc/src/libmsc/smpp_openbsc.c
index 057a9d0..a2fa0f4 100644
--- a/openbsc/src/libmsc/smpp_openbsc.c
+++ b/openbsc/src/libmsc/smpp_openbsc.c
@@ -110,6 +110,7 @@ static int submit_to_sms(struct gsm_sms **psms, struct gsm_network *net,
/* ERROR: we cannot have both! */
LOGP(DLSMS, LOGL_ERROR, "SMPP Cannot have payload in "
"TLV _and_ in the header\n");
+ subscr_put(dest);
return ESME_ROPTPARNOTALLWD;
}
sms_msg = t->value.octet;
@@ -120,6 +121,7 @@ static int submit_to_sms(struct gsm_sms **psms, struct gsm_network *net,
} else {
LOGP(DLSMS, LOGL_ERROR,
"SMPP neither message payload nor valid sm_length.\n");
+ subscr_put(dest);
return ESME_RINVPARLEN;
}