summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHolger Hans Peter Freyther <zecke@selfish.org>2011-04-04 19:17:58 +0200
committerHolger Hans Peter Freyther <zecke@selfish.org>2011-04-04 19:17:58 +0200
commit13673749ffdd8947af5ff69e477f9144e8afc57f (patch)
tree4b75f09e9d35f78ea20a5c8f245a4da3c80de54f
parenta18b11602cb19198544a090078faaa0a826ec19c (diff)
lapd: NULL pointer derefence possible here
The idiom seems to be to allocate the lapd_tei if it does not exist and use it then. This was found by clang --analyze.
-rw-r--r--openbsc/src/libabis/input/lapd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/openbsc/src/libabis/input/lapd.c b/openbsc/src/libabis/input/lapd.c
index 2a4f60e22..c8830d2a8 100644
--- a/openbsc/src/libabis/input/lapd.c
+++ b/openbsc/src/libabis/input/lapd.c
@@ -290,7 +290,7 @@ static void lapd_tei_receive(struct lapd_instance *li, uint8_t *data, int len)
teip = teip_from_tei(li, action);
if (!teip) {
LOGP(DMI, LOGL_INFO, "TEI MGR: New TEI %u\n", action);
- lapd_tei_alloc(li, action);
+ teip = lapd_tei_alloc(li, action);
}
/* Send ACCEPT */