summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeels Hofmeyr <nhofmeyr@sysmocom.de>2016-03-21 11:55:49 +0100
committerNeels Hofmeyr <nhofmeyr@sysmocom.de>2016-03-21 11:56:28 +0100
commit0bc6c11cbf58d6cc7ebafc3ad0bb4a62ce088695 (patch)
tree190c4bc69acf2d17b1101e79cfaf9a3057203a0c
parent182adecb983aeb632315871e0f5d47472d1e19db (diff)
debug log fixes
gprs_gmm.c: remove extraneous debug print arg. iu_cs.c: increment should not be in debug statement. Fixes at least one coverity warning.
-rw-r--r--openbsc/src/gprs/gprs_gmm.c2
-rw-r--r--openbsc/src/libmsc/iu_cs.c3
2 files changed, 3 insertions, 2 deletions
diff --git a/openbsc/src/gprs/gprs_gmm.c b/openbsc/src/gprs/gprs_gmm.c
index 6432a33fe..b2b4bd93f 100644
--- a/openbsc/src/gprs/gprs_gmm.c
+++ b/openbsc/src/gprs/gprs_gmm.c
@@ -117,7 +117,7 @@ int sgsn_ranap_iu_event(struct ue_conn_ctx *ctx, int type, void *data)
case IU_EVENT_IU_RELEASE:
mm->iu.integrity_active = 0;
/* Clean up ue_conn_ctx here */
- LOGMMCTXP(LOGL_INFO, mm, "IU release\n", type);
+ LOGMMCTXP(LOGL_INFO, mm, "IU release\n");
break;
case IU_EVENT_SECURITY_MODE_COMPLETE:
/* Continue authentication here */
diff --git a/openbsc/src/libmsc/iu_cs.c b/openbsc/src/libmsc/iu_cs.c
index bc37d2c92..1b3ce0ab7 100644
--- a/openbsc/src/libmsc/iu_cs.c
+++ b/openbsc/src/libmsc/iu_cs.c
@@ -44,7 +44,7 @@ static inline void log_subscribers(struct gsm_network *network)
struct gsm_subscriber_connection *conn;
int i = 0;
llist_for_each_entry(conn, &network->subscr_conns, entry) {
- DEBUGP(DIUCS, "%3d: %s", i++, subscr_name(conn->subscr));
+ DEBUGP(DIUCS, "%3d: %s", i, subscr_name(conn->subscr));
switch (conn->via_iface) {
case IFACE_IU:
DEBUGPC(DIUCS, " Iu");
@@ -66,6 +66,7 @@ static inline void log_subscribers(struct gsm_network *network)
break;
}
DEBUGPC(DIUCS, "\n");
+ i++;
}
DEBUGP(DIUCS, "subscribers registered: %d\n", i);
}