summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Welte <laforge@gnumonks.org>2014-02-21 13:21:03 +0100
committerHarald Welte <laforge@gnumonks.org>2014-02-21 13:21:03 +0100
commit7e40be3949f99560d07854ee8d90b11237f92e3b (patch)
tree58e1be227e297d63dbd6970fa709c20b4187f75b
parentca114432be6c9e108f0f3182c564d264b78669e0 (diff)
SMPP: UCS2 data_coding is 0x08, not 0x80!
As can clearly be seen from SMPP Spec v3.4 Chapter 5.2.19, a SUBMIT-SM with data_coding == 0x08 is UCS2, not with 0x80. Thanks to ciaby@rhizomatica.org for reporting the bug.
-rw-r--r--openbsc/src/libmsc/smpp_openbsc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/openbsc/src/libmsc/smpp_openbsc.c b/openbsc/src/libmsc/smpp_openbsc.c
index e3093772f..ab558ce9d 100644
--- a/openbsc/src/libmsc/smpp_openbsc.c
+++ b/openbsc/src/libmsc/smpp_openbsc.c
@@ -163,7 +163,7 @@ static int submit_to_sms(struct gsm_sms **psms, struct gsm_network *net,
/* pass DCS 1:1 through from SMPP to GSM */
sms->data_coding_scheme = submit->data_coding;
mode = MODE_8BIT;
- } else if (submit->data_coding == 0x80) {
+ } else if (submit->data_coding == 0x08) {
/* UCS-2 */
sms->data_coding_scheme = (2 << 2);
mode = MODE_8BIT;