diff options
| author | Harald Welte <laforge@gnumonks.org> | 2017-07-17 23:59:39 +0200 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2017-07-18 00:04:28 +0200 |
| commit | 4b731a33783b1eb9cfb83577d8fc414433e20eb0 (patch) | |
| tree | 2721ade2ef2e5c4f811fb005d66b202096ed5f92 | |
| parent | 5daec07de1ea4ab1deb461049f1d6b569353d68b (diff) | |
gtphob: check for missing result of rate_ctr_group_alloc()
In case the counter group allocation fails, we must handle this
gracefully and fail the allocation of the parent object, too.
The recent change (Id I7dad4a4d52fe05f6b990359841b4408df5990e21) seems
to have missed one instance, so let's follow-up.
Change-Id: I1ee9e3d26dcc18e7f979fd9a786162cbcc50942c
Related: OS#2361
| -rw-r--r-- | openbsc/src/gprs/gtphub.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/openbsc/src/gprs/gtphub.c b/openbsc/src/gprs/gtphub.c index 211018b53..5e7520e39 100644 --- a/openbsc/src/gprs/gtphub.c +++ b/openbsc/src/gprs/gtphub.c @@ -2708,6 +2708,10 @@ static struct gtphub_peer_port *gtphub_addr_add_port(struct gtphub_peer_addr *a, pp->counters_io = rate_ctr_group_alloc(osmo_gtphub_ctx, >phub_ctrg_io_desc, 0); + if (!pp->counters_io) { + talloc_free(pp); + return NULL; + } llist_add(&pp->entry, &a->ports); |