summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHolger Hans Peter Freyther <holger@moiji-mobile.com>2013-07-14 08:47:06 +0200
committerHolger Hans Peter Freyther <holger@moiji-mobile.com>2013-07-14 09:04:50 +0200
commitc9251fa8c9e3bc6ea2ea9182e0f1b13b16f065ca (patch)
tree6d09c9cc2e9ffd54af748345fb3793ac5f459c01
parent3aedba66bd06de7e5db0fc38775fa20c29e40033 (diff)
ipaccess: The proxy code checked the array but not the element
Array compared against 0 (NO_EFFECT) array_null: Comparing an array to null is not useful: "ipbc->bsc_rsl_conn". Fixes: Coverity CID 1040718
-rw-r--r--openbsc/src/ipaccess/ipaccess-proxy.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/openbsc/src/ipaccess/ipaccess-proxy.c b/openbsc/src/ipaccess/ipaccess-proxy.c
index 0f03e4e89..9ab4ebbf4 100644
--- a/openbsc/src/ipaccess/ipaccess-proxy.c
+++ b/openbsc/src/ipaccess/ipaccess-proxy.c
@@ -647,7 +647,7 @@ static void reconn_tmr_cb(void *data)
logp_ipbc_uid(DLINP, LOGL_NOTICE, ipbc, priv_nr >> 8);
LOGPC(DLINP, LOGL_NOTICE, "RSL Trying to reconnect\n");
ipbc->bsc_rsl_conn[i] = connect_bsc(&sin, priv_nr, ipbc);
- if (!ipbc->bsc_rsl_conn)
+ if (!ipbc->bsc_rsl_conn[i])
goto reschedule;
logp_ipbc_uid(DLINP, LOGL_NOTICE, ipbc, priv_nr >> 8);
LOGPC(DLINP, LOGL_NOTICE, "RSL Reconnected\n");