diff options
| author | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2015-12-03 11:25:27 +0100 |
|---|---|---|
| committer | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2015-12-03 11:47:25 +0100 |
| commit | 87c83d0b895624ac3968a85edc9de18e36d5d1ea (patch) | |
| tree | bc8b6a7b1bd1a90b11b53203494fd0fb43bea8a3 | |
| parent | d8660ef090b66e7fbbb960ce8a8c8c26f6981c6f (diff) | |
gtphub: improve logging for invalid packet
Sponsored-by: On-Waves ehi
| -rw-r--r-- | openbsc/src/gprs/gtphub.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/openbsc/src/gprs/gtphub.c b/openbsc/src/gprs/gtphub.c index d9c44312b..96068bf5a 100644 --- a/openbsc/src/gprs/gtphub.c +++ b/openbsc/src/gprs/gtphub.c @@ -503,10 +503,8 @@ static void gtp_decode(const uint8_t *data, int data_len, validate_gtp_header(res); - if (res->rc <= 0) { - LOG(LOGL_ERROR, "INVALID: dropping GTP packet.\n"); + if (res->rc <= 0) return; - } LOG(LOGL_DEBUG, "Valid GTP header (v%d)\n", res->version); @@ -2064,8 +2062,13 @@ int gtphub_handle_buf(struct gtphub *hub, struct gtp_packet_desc p; gtp_decode(buf, received, side_idx, plane_idx, &p, now); - if (p.rc <= 0) + if (p.rc <= 0) { + LOG(LOGL_ERROR, "INVALID: dropping GTP packet from %s %s %s\n", + gtphub_side_idx_names[side_idx], + gtphub_plane_idx_names[plane_idx], + osmo_sockaddr_to_str(from_addr)); return -1; + } rate_ctr_inc(&from_bind->counters_io->ctr[GTPH_CTR_PKTS_IN]); |