diff options
| author | Holger Hans Peter Freyther <holger@moiji-mobile.com> | 2013-07-14 09:07:11 +0200 |
|---|---|---|
| committer | Holger Hans Peter Freyther <holger@moiji-mobile.com> | 2013-07-14 09:14:37 +0200 |
| commit | 6a75d16c6d8f9718c925d208538088404c6942aa (patch) | |
| tree | 88c8ad235ecd4d34c98525aa050615f3149ccd10 /src | |
| parent | 2909942a9fe54a8c1f98588dcfece6f4fe35d100 (diff) | |
vty: Fix logically dead code in the description handling
The code most likely wanted to check the result of argv_concat.
To do this we need to dereference the dptr.
Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement "return 1;
Fixes: Coverity CID 1040675
Diffstat (limited to 'src')
| -rw-r--r-- | src/vty/logging_vty.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c index a6d2f522..e17c7a8a 100644 --- a/src/vty/logging_vty.c +++ b/src/vty/logging_vty.c @@ -315,7 +315,7 @@ gDEFUN(cfg_description, cfg_description_cmd, if (*dptr) talloc_free(*dptr); *dptr = argv_concat(argv, argc, 0); - if (!dptr) + if (!*dptr) return CMD_WARNING; return CMD_SUCCESS; |