diff options
| author | Jacob Erlbeck <jerlbeck@sysmocom.de> | 2014-09-23 13:28:21 +0200 |
|---|---|---|
| committer | Holger Hans Peter Freyther <holger@moiji-mobile.com> | 2014-09-23 16:27:44 +0200 |
| commit | a7165778c6696a8853bc7696ffed29dd757b4b0f (patch) | |
| tree | 93b0f2ef26f20084b1f4cb65c5971697105c450d /src/gb/gprs_bssgp.c | |
| parent | de883e7f6cfb71f46921d6ef7564b24aeecd6f2c (diff) | |
gprs: Fix and check BVCI in BSSGP STATUS messages
Currently the BVCI is not set in all invocations to bssgp_tx_status()
when the cause is UNKNOWN_BVCI.
This patch adds the argument where it is missing.
It also adds a check for compliance (GSM 08.18, 10.4.14.1) to
bssgp_tx_status() to emit errors when the following requirement is
not fulfilled: The BVCI must be included if (and only if) the cause
is either "BVCI blocked" or "BVCI unknown".
Sponsored-by: On-Waves ehf
Diffstat (limited to 'src/gb/gprs_bssgp.c')
| -rw-r--r-- | src/gb/gprs_bssgp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c index 5ef18872..b8c6c749 100644 --- a/src/gb/gprs_bssgp.c +++ b/src/gb/gprs_bssgp.c @@ -998,7 +998,7 @@ int bssgp_rcvmsg(struct msgb *msg) LOGP(DBSSGP, LOGL_NOTICE, "NSEI=%u/BVCI=%u Rejecting PDU " "type %u for unknown BVCI\n", msgb_nsei(msg), ns_bvci, pdu_type); - return bssgp_tx_status(BSSGP_CAUSE_UNKNOWN_BVCI, NULL, msg); + return bssgp_tx_status(BSSGP_CAUSE_UNKNOWN_BVCI, &ns_bvci, msg); } if (bctx) { |