diff options
| author | Harald Welte <laforge@gnumonks.org> | 2016-11-26 10:06:07 +0100 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2016-11-26 18:37:57 +0000 |
| commit | edf6fe75b72c10190057c65bdff467e5585ea6d7 (patch) | |
| tree | e1efd8b58da791151b284a8a14fd6fedef82fd04 /src/ctrl/control_cmd.c | |
| parent | aeecc48c45e539e0e176dd13d86423e37ffbcee0 (diff) | |
ctrl_cmd_parse: Make coverity FORWARD_NULL happy
The 'strtok_r' function requires passing a NULL as the first parameter
on subsequent calls in order to ensure the code picks up where it left
off on a previous call. However, Coverity doesn't quite realize this
and points out that if a NULL was passed in as the third argument it
would result in a possible NULL deref because the strtok_r function will
assign the third argument to the first in the call is NULL.
Change-Id: I7a9d08d0d4eae76a5207d285e32a25d1b384a57f
Fixes: Coverity CID 135186
Diffstat (limited to 'src/ctrl/control_cmd.c')
| -rw-r--r-- | src/ctrl/control_cmd.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/ctrl/control_cmd.c b/src/ctrl/control_cmd.c index 3dbcf8f6..2cf66cf3 100644 --- a/src/ctrl/control_cmd.c +++ b/src/ctrl/control_cmd.c @@ -299,6 +299,7 @@ struct ctrl_cmd *ctrl_cmd_parse(void *ctx, struct msgb *msg) msgb_put_u8(msg, 0); str = (char *) msg->l2h; + OSMO_ASSERT(str); tmp = strtok_r(str, " ", &saveptr); if (!tmp) { cmd->type = CTRL_TYPE_ERROR; |