|author||Pablo Neira Ayuso <firstname.lastname@example.org>||2011-03-09 13:05:08 +0100|
|committer||Harald Welte <email@example.com>||2011-03-19 18:33:48 -0300|
vty: integration with logging framework0.1.31
The logging categories are registered by the applications, like osmo-nitb, during startup. Thus, the VTY have to provide the logging commands according to the logging categories that the application has registered. Before this patch, the VTY contained the logging categories hardcoded. Thus, any change in the logging categories by the application would not be shown by the VTY. So far, this was not a problem because all applications used the same logging categories. However, according to what Harald told me, this may be a problem in the future. This patch resolve the lack of integration between the logging framework and the VTY by generating the VTY logging commands from the logging categories registered. Since this patch changes one function of the libosmocore API, it follows another patch for the openbsc application to get in sync with the new function layout. I have reworked and renamed the functions: * log_vty_category_string() * log_vty_level_string() to provide the new ones that generate the exact output that VTY requires. This patch does not release the memory allocated by talloc_zero_size() to store the VTY strings for the commands and the description. I found no exit function that can clean up resources that were allocated.
Diffstat (limited to 'include/osmocom/vty')
1 files changed, 3 insertions, 2 deletions
diff --git a/include/osmocom/vty/logging.h b/include/osmocom/vty/logging.h
index f4e28f88..e0011bf9 100644
@@ -4,8 +4,9 @@
#define LOGGING_STR "Configure log message to this terminal\n"
#define FILTER_STR "Filter log messages\n"
+void logging_vty_add_cmds(const struct log_info *cat);
struct log_target *osmo_log_vty2tgt(struct vty *vty);
#endif /* _VTY_LOGGING_H */