aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Couzens <lynxis@fe80.eu>2021-08-06 18:07:26 +0200
committerlaforge <laforge@osmocom.org>2021-08-13 09:55:51 +0000
commit20ed59103634929efcca10eb0d199cf317e26fbd (patch)
tree72a1daaa107d7b32d65cfe9f34e5f56c519e71fa
parent6a138891da27c2d17288c8efc8e42d578ab3fdf3 (diff)
gprs_ns2_udp: don't start the NSVC fsm for SNS
The SNS code will always create NSVC on it's own. The only case when the SNS dialect allows dynamic NSE/NSVC is on the SGSN side when accepting dynamic NSE and receiving the first SNS SIZE. In this case the NSVC FSM must not be started yet. Prevents sending NS_ALIVE before the SNS configuration has been finished. Change-Id: I86275c99432262b3c19c1ded9a77090b74303bc8
-rw-r--r--src/gb/gprs_ns2_udp.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/gb/gprs_ns2_udp.c b/src/gb/gprs_ns2_udp.c
index 428fd4a8..48160218 100644
--- a/src/gb/gprs_ns2_udp.c
+++ b/src/gb/gprs_ns2_udp.c
@@ -247,7 +247,9 @@ static int handle_nsip_read(struct osmo_fd *bfd)
goto out;
case NS2_CS_CREATED:
ns2_driver_alloc_vc(bind, nsvc, &saddr);
- ns2_vc_fsm_start(nsvc);
+ /* only start the fsm for non SNS. SNS will take care of its own */
+ if (nsvc->nse->dialect != GPRS_NS2_DIALECT_SNS)
+ ns2_vc_fsm_start(nsvc);
break;
}
}