aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJacob Erlbeck <jerlbeck@sysmocom.de>2015-11-17 11:52:26 +0100
committerHolger Hans Peter Freyther <holger@moiji-mobile.com>2015-12-21 13:12:29 +0100
commitf96826f2039a4a794f86ea3d81d3a728a6450847 (patch)
treec892b953eddda16a6bef830b0f728672f73bb933
parent67c96eb2babc9eed8a4a6d3c98ad52eb9ad63877 (diff)
log/test: Extend test case for log_check_level
This commit adds OSMO_ASSERTs for mandatory conditions related to log_check_level, and fprintfs for optional conditions, since it is always safe for log_check_level to return != 0. Sponsored-by: On-Waves ehf
-rw-r--r--tests/logging/logging_test.c10
-rw-r--r--tests/logging/logging_test.err2
2 files changed, 11 insertions, 1 deletions
diff --git a/tests/logging/logging_test.c b/tests/logging/logging_test.c
index b263f905..3c8bac4b 100644
--- a/tests/logging/logging_test.c
+++ b/tests/logging/logging_test.c
@@ -78,16 +78,26 @@ int main(int argc, char **argv)
log_parse_category_mask(stderr_target, "DRLL:DCC");
log_parse_category_mask(stderr_target, "DRLL");
DEBUGP(DCC, "You should not see this\n");
+ if (log_check_level(DMM, LOGL_DEBUG) != 0)
+ fprintf(stderr, "log_check_level did not catch this case\n");
log_parse_category_mask(stderr_target, "DRLL:DCC");
DEBUGP(DRLL, "You should see this\n");
+ OSMO_ASSERT(log_check_level(DRLL, LOGL_DEBUG) != 0);
DEBUGP(DCC, "You should see this\n");
+ OSMO_ASSERT(log_check_level(DCC, LOGL_DEBUG) != 0);
DEBUGP(DMM, "You should not see this\n");
+ if (log_check_level(DMM, LOGL_DEBUG) != 0)
+ fprintf(stderr, "log_check_level did not catch this case\n");
+
OSMO_ASSERT(filter_called == 0);
log_set_all_filter(stderr_target, 0);
DEBUGP(DRLL, "You should not see this and filter is called\n");
OSMO_ASSERT(filter_called == 1);
+ if (log_check_level(DRLL, LOGL_DEBUG) != 0)
+ fprintf(stderr,
+ "log_check_level did not catch this case (filter)\n");
return 0;
}
diff --git a/tests/logging/logging_test.err b/tests/logging/logging_test.err
index b59d2e83..c3b67cc2 100644
--- a/tests/logging/logging_test.err
+++ b/tests/logging/logging_test.err
@@ -1,3 +1,3 @@
You should see this
You should see this
- \ No newline at end of file
+log_check_level did not catch this case (filter)