aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVadim Yanitskiy <vyanitskiy@sysmocom.de>2023-12-11 21:59:27 +0700
committerfixeria <vyanitskiy@sysmocom.de>2023-12-12 13:58:11 +0000
commit9f5ddc408788a71ffd05bd9ee0c14326459f7718 (patch)
tree5a39832a75749b91c302b0a435133ed20222c6ea
parenta7570af87d7c9dd2e63e5782a6f639c022a71cbd (diff)
tests/iuup: fix assert()s in test_decode_passive_init_2_rfci_no_iptis()
We should not be doing the actual logic inside the assert statements. Change-Id: I3bbf4e602c25c5aaced609e9834d6b053688194d Fixes: CID#274664, CID#274679
-rw-r--r--tests/iuup/iuup_test.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/tests/iuup/iuup_test.c b/tests/iuup/iuup_test.c
index e40b9e77..f3aba665 100644
--- a/tests/iuup/iuup_test.c
+++ b/tests/iuup/iuup_test.c
@@ -727,14 +727,18 @@ void test_decode_passive_init_2_rfci_no_iptis(void)
rnp = osmo_iuup_rnl_prim_alloc(iuup_test_ctx, OSMO_IUUP_RNL_CONFIG, PRIM_OP_REQUEST, IUUP_MSGB_SIZE);
rnp->u.config = def_configure_req;
rnp->u.config.active = false;
- OSMO_ASSERT((rc = osmo_iuup_rnl_prim_down(iui, rnp)) == 0);
+
+ rc = osmo_iuup_rnl_prim_down(iui, rnp);
+ OSMO_ASSERT(rc == 0);
/* Send Init: */
tnp = osmo_iuup_tnl_prim_alloc(iuup_test_ctx, OSMO_IUUP_TNL_UNITDATA, PRIM_OP_INDICATION, IUUP_MSGB_SIZE);
tnp->oph.msg->l2h = msgb_put(tnp->oph.msg, sizeof(iuup_init));
hdr14 = (struct iuup_pdutype14_hdr *)msgb_l2(tnp->oph.msg);
memcpy(hdr14, iuup_init, sizeof(iuup_init));
- OSMO_ASSERT((rc = osmo_iuup_tnl_prim_up(iui, tnp)) == 0);
+
+ rc = osmo_iuup_tnl_prim_up(iui, tnp);
+ OSMO_ASSERT(rc == 0);
osmo_iuup_instance_free(iui);
}