diff options
| author | Pau Espin Pedrol <pespin@sysmocom.de> | 2020-01-02 16:21:14 +0100 |
|---|---|---|
| committer | laforge <laforge@osmocom.org> | 2020-01-03 22:16:08 +0000 |
| commit | 57d1118c25ea08dbc84492dfbe8ab15fc7333b4d (patch) | |
| tree | 92913ee2ae073b5c72c6be653affee93cf9f152b | |
| parent | 9b90ca8c44c07a0d146297b2648027d99e6492f2 (diff) | |
logging_vty.c: Avoid acquiring log tgt lock in logging level cmd when not needed
Change-Id: Ia6780221174070cee408625e24513f2c11cc9dfc
| -rw-r--r-- | src/vty/logging_vty.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c index 6d908d9e..c51b4373 100644 --- a/src/vty/logging_vty.c +++ b/src/vty/logging_vty.c @@ -351,18 +351,18 @@ DEFUN(logging_level, int category = log_parse_category(argv[0]); int level = log_parse_level(argv[1]); - ACQUIRE_VTY_LOG_TGT_WITH_LOCK(vty, tgt); - if (level < 0) { vty_out(vty, "Invalid level `%s'%s", argv[1], VTY_NEWLINE); - RET_WITH_UNLOCK(CMD_WARNING); + return CMD_WARNING; } if (category < 0) { vty_out(vty, "Invalid category `%s'%s", argv[0], VTY_NEWLINE); - RET_WITH_UNLOCK(CMD_WARNING); + return CMD_WARNING; } + ACQUIRE_VTY_LOG_TGT_WITH_LOCK(vty, tgt); + tgt->categories[category].enabled = 1; tgt->categories[category].loglevel = level; |