diff options
| author | Vadim Yanitskiy <axilirator@gmail.com> | 2019-03-25 23:41:07 +0700 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2019-03-27 08:56:21 +0100 |
| commit | ba426e3b0c12486a6767000da77492fe50ba26ff (patch) | |
| tree | a99a22ce41c460a68a848e111d4621ab498c281b | |
| parent | 115a2ccae5b02f10e377bd0f339aac875913f18d (diff) | |
core/msgb.h: drop meaningless parameter of msgb_eq_* helpers
Thanks to the following Doxygen warning:
msgb.h:XXX: warning: The following parameters of
msgb_eq_l2(msg1, msgb2, len) are not documented:
parameter 'msgb2'
parameter 'len'
it was discovered that parameter 'len' is not required at all.
It basically doesn't make any sense to pass any length value,
because it can be calculated using msgb_length().
Let's drop this parameter. Given that this part of the API was
broken so far (see I1079d629abdb8770eef6be7341e586a933cd9cca),
it should be more or less safe to do this.
Change-Id: Icd9b72eb6bfa9628ff1ed2f948b57058551a4328
| -rw-r--r-- | include/osmocom/core/msgb.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/include/osmocom/core/msgb.h b/include/osmocom/core/msgb.h index 5de391e1..273fc161 100644 --- a/include/osmocom/core/msgb.h +++ b/include/osmocom/core/msgb.h @@ -668,35 +668,35 @@ bool _msgb_eq(const char *file, size_t line, const char *func, uint8_t level, * \param[in] msg2 reference message buffer * \returns boolean indicating whether msgb content is equal */ -#define msgb_eq(msg1, msg2, len) msgb_eq_data(msg1, msgb_data(msg2), msgb_length(msg2)) +#define msgb_eq(msg1, msg2) msgb_eq_data(msg1, msgb_data(msg2), msgb_length(msg2)) /*! Compare msgbs L1 content * \param[in] msg1 message buffer * \param[in] msg2 reference message buffer * \returns boolean indicating whether msgb L1 content is equal */ -#define msgb_eq_l1(msg1, msg2, len) msgb_eq_l1_data(msg1, msgb_l1(msg2), msgb_l1len(msg2)) +#define msgb_eq_l1(msg1, msg2) msgb_eq_l1_data(msg1, msgb_l1(msg2), msgb_l1len(msg2)) /*! Compare msgbs L2 content * \param[in] msg1 message buffer * \param[in] msg2 reference message buffer * \returns boolean indicating whether msgb L2 content is equal */ -#define msgb_eq_l2(msg1, msg2, len) msgb_eq_l2_data(msg1, msgb_l2(msg2), msgb_l2len(msg2)) +#define msgb_eq_l2(msg1, msg2) msgb_eq_l2_data(msg1, msgb_l2(msg2), msgb_l2len(msg2)) /*! Compare msgbs L3 content * \param[in] msg1 message buffer * \param[in] msg2 reference message buffer * \returns boolean indicating whether msgb L3 content is equal */ -#define msgb_eq_l3(msg1, msg2, len) msgb_eq_l3_data(msg1, msgb_l3(msg2), msgb_l3len(msg2)) +#define msgb_eq_l3(msg1, msg2) msgb_eq_l3_data(msg1, msgb_l3(msg2), msgb_l3len(msg2)) /*! Compare msgbs L4 content * \param[in] msg1 message buffer * \param[in] msg2 reference message buffer * \returns boolean indicating whether msgb L4 content is equal */ -#define msgb_eq_l4(msg1, msg2, len) msgb_eq_l4_data(msg1, msgb_l4(msg2), msgb_l4len(msg2)) +#define msgb_eq_l4(msg1, msg2) msgb_eq_l4_data(msg1, msgb_l4(msg2), msgb_l4len(msg2)) /* non inline functions to ease binding */ |