aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Welte <laforge@osmocom.org>2021-02-05 14:49:21 +0100
committerHarald Welte <laforge@osmocom.org>2021-02-08 18:36:21 +0100
commitb339cbb3efc8eb4fc69785588f1d1686d8fabe68 (patch)
tree7f1f68d7d4693c804cbc51730d79a9c150bee52a
parent15b5acb332f49f31e2719510f447622b0b5ad7d5 (diff)
ns2: Name NSVC FSM events consistently
Reading a log line like this: <0026> gprs_ns2_vc_fsm.c:808 GPRS-NS2-VC(FR-hdlcnet1-DLCI16-NSE02001-NSVC00001)[0x6120000024a0]{UNBLOCKED}: Received Event RESET is very ambiguous. Does it mean we received a NS-RESET message? Does it mean the FSM was instructed to send a NS-RESET? ... Let's make sure the human-readable names give a very clear indication of what exactly is happening. Change-Id: I8b7615b3eca04212831163ff0ea4aea35069cd0e
-rw-r--r--src/gb/gprs_ns2_vc_fsm.c24
1 files changed, 12 insertions, 12 deletions
diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c
index f6424de4..66ee4505 100644
--- a/src/gb/gprs_ns2_vc_fsm.c
+++ b/src/gb/gprs_ns2_vc_fsm.c
@@ -122,18 +122,18 @@ enum gprs_ns2_vc_event {
};
static const struct value_string ns2_vc_event_names[] = {
- { GPRS_NS2_EV_REQ_START, "START" },
- { GPRS_NS2_EV_RX_RESET, "RESET" },
- { GPRS_NS2_EV_RX_RESET_ACK, "RESET_ACK" },
- { GPRS_NS2_EV_RX_UNBLOCK, "UNBLOCK" },
- { GPRS_NS2_EV_RX_UNBLOCK_ACK, "UNBLOCK_ACK" },
- { GPRS_NS2_EV_RX_BLOCK, "BLOCK" },
- { GPRS_NS2_EV_RX_BLOCK_ACK, "BLOCK_ACK" },
- { GPRS_NS2_EV_RX_ALIVE, "ALIVE" },
- { GPRS_NS2_EV_RX_ALIVE_ACK, "ALIVE_ACK" },
- { GPRS_NS2_EV_RX_STATUS, "STATUS" },
- { GPRS_NS2_EV_RX_UNITDATA, "UNITDATA" },
- { GPRS_NS2_EV_REQ_FORCE_UNCONFIGURED, "FORCE_UNCONFIGURED" },
+ { GPRS_NS2_EV_REQ_START, "REQ-START" },
+ { GPRS_NS2_EV_RX_RESET, "RX-RESET" },
+ { GPRS_NS2_EV_RX_RESET_ACK, "RX-RESET_ACK" },
+ { GPRS_NS2_EV_RX_UNBLOCK, "RX-UNBLOCK" },
+ { GPRS_NS2_EV_RX_UNBLOCK_ACK, "RX-UNBLOCK_ACK" },
+ { GPRS_NS2_EV_RX_BLOCK, "RX-BLOCK" },
+ { GPRS_NS2_EV_RX_BLOCK_ACK, "RX-BLOCK_ACK" },
+ { GPRS_NS2_EV_RX_ALIVE, "RX-ALIVE" },
+ { GPRS_NS2_EV_RX_ALIVE_ACK, "RX-ALIVE_ACK" },
+ { GPRS_NS2_EV_RX_STATUS, "RX-STATUS" },
+ { GPRS_NS2_EV_RX_UNITDATA, "RX-UNITDATA" },
+ { GPRS_NS2_EV_REQ_FORCE_UNCONFIGURED, "REQ-FORCE_UNCONFIGURED" },
{ GPRS_NS2_EV_REQ_OM_BLOCK, "REQ-O&M-BLOCK"},
{ GPRS_NS2_EV_REQ_OM_UNBLOCK, "REQ-O&M-UNBLOCK"},
{ 0, NULL }