diff options
| author | Alexander Couzens <lynxis@fe80.eu> | 2020-12-10 00:20:18 +0100 |
|---|---|---|
| committer | lynxis lazus <lynxis@fe80.eu> | 2020-12-20 15:34:53 +0000 |
| commit | 3c22f91bad6b2e861003ce83ad4b514317be1b50 (patch) | |
| tree | 1e9e1af77726f48cac562daf205b26c4536fe3fe | |
| parent | 12e5e6bd78ea8c709a83886bb94567ce889fa001 (diff) | |
gprs_ns2: don't pass the return code of reject_status_msg
When reject_stats_msg() fails the code can't do anything about it.
Stick to the original failure code and log it
Change-Id: I105363957e59c41a68835b7a9830c048dba73e93
| -rw-r--r-- | src/gb/gprs_ns2.c | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c index 49606d86..5603fce4 100644 --- a/src/gb/gprs_ns2.c +++ b/src/gb/gprs_ns2.c @@ -832,18 +832,13 @@ enum gprs_ns2_cs ns2_create_vc(struct gprs_ns2_vc_bind *bind, } rc = reject_status_msg(msg, &tp, reject, NS_CAUSE_PDU_INCOMP_PSTATE); - if (rc < 0) { + if (rc < 0) LOGP(DLNS, LOGL_ERROR, "Failed to generate reject message (%d)\n", rc); - return rc; - } return GPRS_NS2_CS_REJECTED; default: rc = reject_status_msg(msg, &tp, reject, NS_CAUSE_PDU_INCOMP_PSTATE); - - if (rc < 0) { + if (rc < 0) LOGP(DLNS, LOGL_ERROR, "Failed to generate reject message (%d)\n", rc); - return rc; - } return GPRS_NS2_CS_REJECTED; } @@ -854,10 +849,8 @@ enum gprs_ns2_cs ns2_create_vc(struct gprs_ns2_vc_bind *bind, LOGP(DLNS, LOGL_ERROR, "Rx NS RESET Error %d during " "TLV Parse\n", tlv); rc = reject_status_msg(msg, &tp, reject, NS_CAUSE_PROTO_ERR_UNSPEC); - if (rc < 0) { + if (rc < 0) LOGP(DLNS, LOGL_ERROR, "Failed to generate reject message (%d)\n", rc); - return rc; - } return GPRS_NS2_CS_REJECTED; } @@ -865,6 +858,8 @@ enum gprs_ns2_cs ns2_create_vc(struct gprs_ns2_vc_bind *bind, !TLVP_PRES_LEN(&tp, NS_IE_VCI, 2) || !TLVP_PRES_LEN(&tp, NS_IE_NSEI, 2)) { LOGP(DLNS, LOGL_ERROR, "NS RESET Missing mandatory IE\n"); rc = reject_status_msg(msg, &tp, reject, NS_CAUSE_MISSING_ESSENT_IE); + if (rc < 0) + LOGP(DLNS, LOGL_ERROR, "Failed to generate reject message (%d)\n", rc); return GPRS_NS2_CS_REJECTED; } |