From a17ecfa7b174f0104ff124666706662dd88394b5 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Fri, 17 Nov 2017 02:55:35 +0100 Subject: sccp_test: sanitize: don't memcmp NULL pointers Change-Id: I0159a875c1e11f4f9728d9e09f5c365b8174673a --- tests/sccp/sccp_test.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/sccp/sccp_test.c b/tests/sccp/sccp_test.c index d6abc5d..ed485bc 100644 --- a/tests/sccp/sccp_test.c +++ b/tests/sccp/sccp_test.c @@ -886,15 +886,17 @@ static void test_sccp_parsing(void) FAIL("GTI length is wrong: %d\n", result.called.gti_len); } - if (memcmp(&parse_result[current_test].dst_gti_data[0], - result.called.gti_data, result.called.gti_len) != 0) { + if (parse_result[current_test].dst_gti_data + && memcmp(&parse_result[current_test].dst_gti_data[0], + result.called.gti_data, result.called.gti_len) != 0) { FAIL("GTI data is wrong: %d '%s'\n", result.called.gti_len, osmo_hexdump(result.called.gti_data, result.called.gti_len)); } - if (memcmp(&parse_result[current_test].src_gti_data[0], - result.calling.gti_data, result.calling.gti_len) != 0) { + if (parse_result[current_test].src_gti_data + && memcmp(&parse_result[current_test].src_gti_data[0], + result.calling.gti_data, result.calling.gti_len) != 0) { FAIL("GTI data is wrong: %d\n", result.calling.gti_len); } } -- cgit v1.2.3