summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeels Hofmeyr <nhofmeyr@sysmocom.de>2016-06-13 12:17:44 +0200
committerHarald Welte <laforge@gnumonks.org>2016-06-14 10:36:23 +0000
commit1a698a537d2250f7161867a578288db27fe0435c (patch)
tree3c640d99e2e575ffd6b9044021f1f966a5092fdb
parent5abdbebc3ae10fc3c21922406a18f20fdbdc00f7 (diff)
clarify fixme comment, x7
The fixme is about an actual message sent back, not about the error log. Change-Id: I6de8fb202c7beb025232e9b97605e9f46778506a Reviewed-on: https://gerrit.osmocom.org/228 Tested-by: Jenkins Builder Reviewed-by: Harald Welte <laforge@gnumonks.org>
-rw-r--r--src/sua.c14
1 files changed, 7 insertions, 7 deletions
diff --git a/src/sua.c b/src/sua.c
index 6e187d8..89182d2 100644
--- a/src/sua.c
+++ b/src/sua.c
@@ -846,7 +846,7 @@ static int sua_rx_coak(struct osmo_sua_link *link, struct xua_msg *xua)
if (!conn) {
LOGP(DSUA, LOGL_ERROR, "COAK for unknwon reference %u\n",
conn_id);
- /* FIXME: error message? */
+ /* FIXME: send error reply down the sua link? */
return -1;
}
conn_restart_rx_inact_timer(conn);
@@ -854,7 +854,7 @@ static int sua_rx_coak(struct osmo_sua_link *link, struct xua_msg *xua)
if (conn->state != S_CONN_PEND_OUT) {
LOGP(DSUA, LOGL_ERROR, "COAK in wrong state %s\n",
get_value_string(conn_state_names, conn->state));
- /* FIXME: error message? */
+ /* FIXME: send error reply down the sua link? */
return -EINVAL;
}
@@ -908,7 +908,7 @@ static int sua_rx_coref(struct osmo_sua_link *link, struct xua_msg *xua)
if (!conn) {
LOGP(DSUA, LOGL_ERROR, "COREF for unknwon reference %u\n",
conn_id);
- /* FIXME: error message? */
+ /* FIXME: send error reply down the sua link? */
return -1;
}
conn_restart_rx_inact_timer(conn);
@@ -961,7 +961,7 @@ static int sua_rx_relre(struct osmo_sua_link *link, struct xua_msg *xua)
if (!conn) {
LOGP(DSUA, LOGL_ERROR, "RELRE for unknwon reference %u\n",
conn_id);
- /* FIXME: error message? */
+ /* FIXME: send error reply down the sua link? */
return -1;
}
@@ -1011,7 +1011,7 @@ static int sua_rx_relco(struct osmo_sua_link *link, struct xua_msg *xua)
if (!conn) {
LOGP(DSUA, LOGL_ERROR, "RELCO for unknwon reference %u\n",
conn_id);
- /* FIXME: error message? */
+ /* FIXME: send error reply down the sua link? */
return -1;
}
conn_restart_rx_inact_timer(conn);
@@ -1058,14 +1058,14 @@ static int sua_rx_codt(struct osmo_sua_link *link, struct xua_msg *xua)
if (!conn) {
LOGP(DSUA, LOGL_ERROR, "DT1 for unknwon reference %u\n",
conn_id);
- /* FIXME: error message? */
+ /* FIXME: send error reply down the sua link? */
return -1;
}
if (conn->state != S_ACTIVE) {
LOGP(DSUA, LOGL_ERROR, "DT1 in invalid state %s\n",
get_value_string(conn_state_names, conn->state));
- /* FIXME: error message? */
+ /* FIXME: send error reply down the sua link? */
return -1;
}