ipaccess: relax default behaviour on errors coming from signalling layer

This patch relaxes the behaviour on error coming from the signalling
layer. This is probably too strict for recoverable errors.

Don't release msgb in this case, as this is controled by the signaling link
layer.

Thanks to Lennart Müller <mueller.lennart@googlemail.com> for the report.

1 files changed, 4 insertions, 2 deletions

diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index d63e796..5e76a09 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -450,10 +450,12 @@ static int handle_ts1_read(struct osmo_fd *bfd)
 		goto err_msg;
 	}
 	if (e1i_ts->line->ops->sign_link(msg) < 0) {
+		/* Don't close the signalling link if the upper layers report
+		 * an error, that's too strict. BTW, the signalling layer is
+		 * resposible for releasing the message.
+		 */
 		LOGP(DLINP, LOGL_ERROR, "Bad signalling message,"
 			"sign_link returned error\n");
-		ret = -EINVAL;
-		goto err;
 	}
 
 	return 0;